Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: Source/core/inspector/InspectorInstrumentation.idl

Issue 206073005: PassRefPtr is stolen by first agent invocation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 * Inline=FastReturn - return early from the inline method if there are no frontends. 45 * Inline=FastReturn - return early from the inline method if there are no frontends.
46 * Inline=Forward - generate a simple forwarding inline method that doe s not 46 * Inline=Forward - generate a simple forwarding inline method that doe s not
47 modify the parameter list (implies Inline=FastRetur n) 47 modify the parameter list (implies Inline=FastRetur n)
48 * Attributes without "=" are the names of the agents to be invoked. 48 * Attributes without "=" are the names of the agents to be invoked.
49 * Examples: DOM, Page, Debugger. 49 * Examples: DOM, Page, Debugger.
50 * 50 *
51 * paramAttr - optional attribute controlling the parameters handling (one attr ibute per parameter max). 51 * paramAttr - optional attribute controlling the parameters handling (one attr ibute per parameter max).
52 * Keep - pass first parameter (used to access the InstrumentingAgents inst ance) to agents. 52 * Keep - pass first parameter (used to access the InstrumentingAgents inst ance) to agents.
53 * FastReturn - return early from the inline method if this parameter is 0/ false. 53 * FastReturn - return early from the inline method if this parameter is 0/ false.
54 * 54 *
55 * returnValue: C++ return value. Only "void" and "InspectorInstrumentationCook ie" are supported. 55 * returnValue: C++ return value. Only "void" and "InspectorInstrumentationCook ie" are supported.
aandrey 2014/03/20 06:16:11 could you plz add "bool" here?
56 * 56 *
57 * methodName: C++ name for the public instrumentation method and agents method s. 57 * methodName: C++ name for the public instrumentation method and agents method s.
58 * 58 *
59 * paramList: C++ parameter list with optional names. Names will be deduced fro m types if omitted but you have to 59 * paramList: C++ parameter list with optional names. Names will be deduced fro m types if omitted but you have to
60 * specify explicit names for multiple parameters of the same type. 60 * specify explicit names for multiple parameters of the same type.
61 *
62 * Parameters with type PassRefPtr<T> are converted to raw pointers,
63 * so reference will not be passed or released until all agents are notified.
61 */ 64 */
62 65
63 interface InspectorInstrumentation { 66 interface InspectorInstrumentation {
64 67
65 #include "core/dom/PseudoElement.h" 68 #include "core/dom/PseudoElement.h"
66 69
67 [Page, Inspector, PageDebugger, PageRuntime] 70 [Page, Inspector, PageDebugger, PageRuntime]
68 void didClearWindowObjectInMainWorld([Keep] LocalFrame*); 71 void didClearWindowObjectInMainWorld([Keep] LocalFrame*);
69 72
70 [DOMDebugger, Inline=FastReturn] 73 [DOMDebugger, Inline=FastReturn]
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 540
538 [Debugger, Inline=FastReturn] 541 [Debugger, Inline=FastReturn]
539 void didCreatePromise(ExecutionContext*, const ScriptObject& promise); 542 void didCreatePromise(ExecutionContext*, const ScriptObject& promise);
540 543
541 [Debugger, Inline=FastReturn] 544 [Debugger, Inline=FastReturn]
542 void didUpdatePromiseParent(ExecutionContext*, const ScriptObject& promise, const ScriptObject& parentPromise); 545 void didUpdatePromiseParent(ExecutionContext*, const ScriptObject& promise, const ScriptObject& parentPromise);
543 546
544 [Debugger, Inline=FastReturn] 547 [Debugger, Inline=FastReturn]
545 void didUpdatePromiseState(ExecutionContext*, const ScriptObject& promise, V 8PromiseCustom::PromiseState, const ScriptValue& result); 548 void didUpdatePromiseState(ExecutionContext*, const ScriptObject& promise, V 8PromiseCustom::PromiseState, const ScriptValue& result);
546 } 549 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698