Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2060633002: mash: Introduce WmSystemTrayNotifier for //ash/common (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
msw, stevenjb
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@testupdate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Introduce WmSystemTrayNotifier for //ash/common SystemTrayNotifier is a dependency of TrayUpdate, which I am trying to move to //ash/common. SystemTrayNotifier has a large number of dependencies, so split out a new version called WmSystemTrayNotifier where we can port dependencies one by one. Move update notifications to WmSystemTrayObserver. BUG=615155 TEST=existing ash_unittests, specifically TrayUpdateTest Committed: https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5 Cr-Commit-Position: refs/heads/master@{#399473}

Patch Set 1 #

Patch Set 2 : forward declare #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -31 lines) Patch
M ash/ash.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A ash/common/system/tray/wm_system_tray_notifier.h View 1 1 chunk +40 lines, -0 lines 0 comments Download
A ash/common/system/tray/wm_system_tray_notifier.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M ash/common/wm_shell.h View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M ash/common/wm_shell.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/tray/system_tray_notifier.h View 5 chunks +0 lines, -8 lines 0 comments Download
M ash/system/tray/system_tray_notifier.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M ash/system/tray_update.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/system/tray_update_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 3 chunks +8 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
James Cook
msw, please take a look.
4 years, 6 months ago (2016-06-11 00:02:10 UTC) #2
msw
lgtm
4 years, 6 months ago (2016-06-11 00:20:46 UTC) #3
James Cook
stevenjb, can I get OWNERS for chrome/browser/ui/ash/system_tray_delegate_chromeos.* ?
4 years, 6 months ago (2016-06-11 23:37:24 UTC) #5
stevenjb
lgtm
4 years, 6 months ago (2016-06-13 16:57:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060633002/60001
4 years, 6 months ago (2016-06-13 17:19:11 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-13 17:25:00 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 17:26:51 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9e501c6be0f10c1bbdbc8baea5beb24ff39b08a5
Cr-Commit-Position: refs/heads/master@{#399473}

Powered by Google App Engine
This is Rietveld 408576698