tools/clang/blink_gc_plugin/tests/templated_class_with_local_class_requires_trace.txt - Issue 2060553002: GC plugin: improve error reporting when tracing illegal fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/templated_class_with_local_class_requires_trace.txt

Issue 2060553002: GC plugin: improve error reporting when tracing illegal fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: robustify namespace equality checking instead Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/blink_gc_plugin/tests/templated_class_with_local_class_requires_trace.txt

diff --git a/tools/clang/blink_gc_plugin/tests/templated_class_with_local_class_requires_trace.txt b/tools/clang/blink_gc_plugin/tests/templated_class_with_local_class_requires_trace.txt

index ed0dbcae5a8c5b078689719d0a7a1e108cbd6cf1..fa6b9f544a0e6443c8a6ebdefc4866f7e7026774 100644

--- a/tools/clang/blink_gc_plugin/tests/templated_class_with_local_class_requires_trace.txt

+++ b/tools/clang/blink_gc_plugin/tests/templated_class_with_local_class_requires_trace.txt

@@ -17,4 +17,10 @@ class TemplatedObject final

./templated_class_with_local_class_requires_trace.h:41:9: note: [blink-gc] Field 'm_object' requiring finalization declared here:

OwnPtr<HeapObject> m_object;

-3 warnings generated.

+./templated_class_with_local_class_requires_trace.h:34:9: warning: [blink-gc] Class 'Local' has untraced or not traceable fields.

+ void trace(Visitor* visitor)

+ ^

+./templated_class_with_local_class_requires_trace.h:41:9: note: [blink-gc] Untraceable field 'm_object' declared here:

+ OwnPtr<HeapObject> m_object;

+ ^

+4 warnings generated.

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/persistent_no_trace.txt ('k') | no next file » | no next file with comments »