Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/templated_class_with_local_class_requires_trace.txt

Issue 2060553002: GC plugin: improve error reporting when tracing illegal fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: robustify namespace equality checking instead Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/persistent_no_trace.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 In file included from templated_class_with_local_class_requires_trace.cpp:5: 1 In file included from templated_class_with_local_class_requires_trace.cpp:5:
2 ./templated_class_with_local_class_requires_trace.h:22:1: warning: [blink-gc] Cl ass 'TemplatedObject<blink::HeapObject>' contains invalid fields. 2 ./templated_class_with_local_class_requires_trace.h:22:1: warning: [blink-gc] Cl ass 'TemplatedObject<blink::HeapObject>' contains invalid fields.
3 class TemplatedObject final 3 class TemplatedObject final
4 ^ 4 ^
5 ./templated_class_with_local_class_requires_trace.h:46:5: note: [blink-gc] OwnPt r field 'm_ownRef' to a GC managed class declared here: 5 ./templated_class_with_local_class_requires_trace.h:46:5: note: [blink-gc] OwnPt r field 'm_ownRef' to a GC managed class declared here:
6 OwnPtr<T> m_ownRef; 6 OwnPtr<T> m_ownRef;
7 ^ 7 ^
8 ./templated_class_with_local_class_requires_trace.h:32:5: warning: [blink-gc] Cl ass 'Local' contains invalid fields. 8 ./templated_class_with_local_class_requires_trace.h:32:5: warning: [blink-gc] Cl ass 'Local' contains invalid fields.
9 class Local final : public GarbageCollected<Local> { 9 class Local final : public GarbageCollected<Local> {
10 ^ 10 ^
11 ./templated_class_with_local_class_requires_trace.h:41:9: note: [blink-gc] OwnPt r field 'm_object' to a GC managed class declared here: 11 ./templated_class_with_local_class_requires_trace.h:41:9: note: [blink-gc] OwnPt r field 'm_object' to a GC managed class declared here:
12 OwnPtr<HeapObject> m_object; 12 OwnPtr<HeapObject> m_object;
13 ^ 13 ^
14 ./templated_class_with_local_class_requires_trace.h:32:5: warning: [blink-gc] Cl ass 'Local' requires finalization. 14 ./templated_class_with_local_class_requires_trace.h:32:5: warning: [blink-gc] Cl ass 'Local' requires finalization.
15 class Local final : public GarbageCollected<Local> { 15 class Local final : public GarbageCollected<Local> {
16 ^ 16 ^
17 ./templated_class_with_local_class_requires_trace.h:41:9: note: [blink-gc] Field 'm_object' requiring finalization declared here: 17 ./templated_class_with_local_class_requires_trace.h:41:9: note: [blink-gc] Field 'm_object' requiring finalization declared here:
18 OwnPtr<HeapObject> m_object; 18 OwnPtr<HeapObject> m_object;
19 ^ 19 ^
20 3 warnings generated. 20 ./templated_class_with_local_class_requires_trace.h:34:9: warning: [blink-gc] Cl ass 'Local' has untraced or not traceable fields.
21 void trace(Visitor* visitor)
22 ^
23 ./templated_class_with_local_class_requires_trace.h:41:9: note: [blink-gc] Untra ceable field 'm_object' declared here:
24 OwnPtr<HeapObject> m_object;
25 ^
26 4 warnings generated.
OLDNEW
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/persistent_no_trace.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698