Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/clang/blink_gc_plugin/tests/persistent_no_trace.h

Issue 2060553002: GC plugin: improve error reporting when tracing illegal fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: robustify namespace equality checking instead Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/persistent_no_trace.h
diff --git a/tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.h b/tools/clang/blink_gc_plugin/tests/persistent_no_trace.h
similarity index 50%
copy from tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.h
copy to tools/clang/blink_gc_plugin/tests/persistent_no_trace.h
index f3fa506a4ca05277cdc729c09aca95b03731f0db..c8beb9962c2c9f298429a8dcede29c81bdf4ae10 100644
--- a/tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.h
+++ b/tools/clang/blink_gc_plugin/tests/persistent_no_trace.h
@@ -1,9 +1,9 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef DESTRUCTOR_IN_NONFINALIZED_CLASS_H_
-#define DESTRUCTOR_IN_NONFINALIZED_CLASS_H_
+#ifndef PERSISTENT_NO_TRACE_H_
+#define PERSISTENT_NO_TRACE_H_
#include "heap/stubs.h"
@@ -11,10 +11,10 @@ namespace blink {
class HeapObject : public GarbageCollected<HeapObject> {
public:
- ~HeapObject();
void trace(Visitor*);
private:
- Member<HeapObject> m_obj;
+ CrossThreadPersistent<HeapObject> m_crossThreadPersistent;
+ CrossThreadWeakPersistent<HeapObject> m_crossThreadWeakPersistent;
};
}

Powered by Google App Engine
This is Rietveld 408576698