tools/clang/blink_gc_plugin/tests/persistent_field_in_gc_managed_class.txt - Issue 2060553002: GC plugin: improve error reporting when tracing illegal fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/persistent_field_in_gc_managed_class.txt

Issue 2060553002: GC plugin: improve error reporting when tracing illegal fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: robustify namespace equality checking instead Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/persistent_field_in_gc_managed_class.h ('k') | tools/clang/blink_gc_plugin/tests/persistent_no_trace.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/persistent_field_in_gc_managed_class.txt

diff --git a/tools/clang/blink_gc_plugin/tests/persistent_field_in_gc_managed_class.txt b/tools/clang/blink_gc_plugin/tests/persistent_field_in_gc_managed_class.txt

index d69c0c57f7d4fa8a734918c60e7315fc41abd7c5..dd5bc74a9567a04b48015cf3020ed3c0771579cd 100644

--- a/tools/clang/blink_gc_plugin/tests/persistent_field_in_gc_managed_class.txt

+++ b/tools/clang/blink_gc_plugin/tests/persistent_field_in_gc_managed_class.txt

@@ -23,4 +23,10 @@ class HeapObject : public GarbageCollected<HeapObject> {

./persistent_field_in_gc_managed_class.h:26:5: note: [blink-gc] Field 'm_objs' defining a GC root declared here:

PersistentHeapVector<Member<HeapObject> > m_objs;

-3 warnings generated.

+./persistent_field_in_gc_managed_class.h:20:1: warning: [blink-gc] Class 'HeapObject' contains GC root in field 'm_weakPersistent'.

+class HeapObject : public GarbageCollected<HeapObject> {

+./persistent_field_in_gc_managed_class.h:27:5: note: [blink-gc] Field 'm_weakPersistent' defining a GC root declared here:

+ WeakPersistent<HeapObject> m_weakPersistent;

+ ^

+4 warnings generated.