tools/clang/blink_gc_plugin/RecordInfo.h - Issue 2060553002: GC plugin: improve error reporting when tracing illegal fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/RecordInfo.h

Issue 2060553002: GC plugin: improve error reporting when tracing illegal fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/blink_gc_plugin/RecordInfo.h

diff --git a/tools/clang/blink_gc_plugin/RecordInfo.h b/tools/clang/blink_gc_plugin/RecordInfo.h

index 39c13f01c6dd9dca7134df1787854fd8b7e27a41..616d4f4e40c8055d4f6cc0d698a8fc6aeb1e0dbe 100644

--- a/tools/clang/blink_gc_plugin/RecordInfo.h

+++ b/tools/clang/blink_gc_plugin/RecordInfo.h

@@ -26,6 +26,7 @@ class GraphPoint {

virtual ~GraphPoint() {}

void MarkTraced() { traced_ = true; }

bool IsProperlyTraced() { return traced_ || !NeedsTracing().IsNeeded(); }

+ bool IsInproperlyTraced() { return traced_ && NeedsTracing().IsIllegal(); }

virtual const TracingStatus NeedsTracing() = 0;

private:

« no previous file with comments | « tools/clang/blink_gc_plugin/Edge.cpp ('k') | tools/clang/blink_gc_plugin/RecordInfo.cpp » ('j') | tools/clang/blink_gc_plugin/RecordInfo.cpp » ('J')