Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: tools/clang/blink_gc_plugin/RecordInfo.h

Issue 2060553002: GC plugin: improve error reporting when tracing illegal fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file provides a wrapper for CXXRecordDecl that accumulates GC related 5 // This file provides a wrapper for CXXRecordDecl that accumulates GC related
6 // information about a class. Accumulated information is memoized and the info 6 // information about a class. Accumulated information is memoized and the info
7 // objects are stored in a RecordCache. 7 // objects are stored in a RecordCache.
8 8
9 #ifndef TOOLS_BLINK_GC_PLUGIN_RECORD_INFO_H_ 9 #ifndef TOOLS_BLINK_GC_PLUGIN_RECORD_INFO_H_
10 #define TOOLS_BLINK_GC_PLUGIN_RECORD_INFO_H_ 10 #define TOOLS_BLINK_GC_PLUGIN_RECORD_INFO_H_
11 11
12 #include <map> 12 #include <map>
13 #include <vector> 13 #include <vector>
14 14
15 #include "Edge.h" 15 #include "Edge.h"
16 16
17 #include "clang/AST/AST.h" 17 #include "clang/AST/AST.h"
18 #include "clang/AST/CXXInheritance.h" 18 #include "clang/AST/CXXInheritance.h"
19 19
20 class RecordCache; 20 class RecordCache;
21 21
22 // A potentially tracable and/or lifetime affecting point in the object graph. 22 // A potentially tracable and/or lifetime affecting point in the object graph.
23 class GraphPoint { 23 class GraphPoint {
24 public: 24 public:
25 GraphPoint() : traced_(false) {} 25 GraphPoint() : traced_(false) {}
26 virtual ~GraphPoint() {} 26 virtual ~GraphPoint() {}
27 void MarkTraced() { traced_ = true; } 27 void MarkTraced() { traced_ = true; }
28 bool IsProperlyTraced() { return traced_ || !NeedsTracing().IsNeeded(); } 28 bool IsProperlyTraced() { return traced_ || !NeedsTracing().IsNeeded(); }
29 bool IsInproperlyTraced() { return traced_ && NeedsTracing().IsIllegal(); }
29 virtual const TracingStatus NeedsTracing() = 0; 30 virtual const TracingStatus NeedsTracing() = 0;
30 31
31 private: 32 private:
32 bool traced_; 33 bool traced_;
33 }; 34 };
34 35
35 class BasePoint : public GraphPoint { 36 class BasePoint : public GraphPoint {
36 public: 37 public:
37 BasePoint(const clang::CXXBaseSpecifier& spec, 38 BasePoint(const clang::CXXBaseSpecifier& spec,
38 RecordInfo* info, 39 RecordInfo* info,
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 } 188 }
188 } 189 }
189 } 190 }
190 191
191 private: 192 private:
192 typedef std::map<clang::CXXRecordDecl*, RecordInfo> Cache; 193 typedef std::map<clang::CXXRecordDecl*, RecordInfo> Cache;
193 Cache cache_; 194 Cache cache_;
194 }; 195 };
195 196
196 #endif // TOOLS_BLINK_GC_PLUGIN_RECORD_INFO_H_ 197 #endif // TOOLS_BLINK_GC_PLUGIN_RECORD_INFO_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698