Watch for RenderFrameHost switch in distillability

Watch for RenderFrameHost switch in distillability

When navigating to/from a native page, the RenderFrameHost would
switch and the distillability service would lose connection. This
would cause Reader Mode to be broken for a few navigations. The
DistillabilityDriver now listens for this switch and updates the
service accordingly.

BUG=615327
Committed: https://crrev.com/acf19900a4a4dafcbac2ef2258522abf5f81ba9c
Cr-Commit-Position: refs/heads/master@{#402245}

[mdjones, 2016-06-13 21:24:52]

mdjones@chromium.org changed reviewers:
+ wychen@chromium.org

[mdjones, 2016-06-13 21:24:53]

ptal

[wychen, 2016-06-20 18:34:22]

Looks reasonable. I think it might be good to also add a test to
src/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc to catch
this.

[mdjones, 2016-06-20 23:59:33]

On 2016/06/20 18:34:22, wychen wrote:
> Looks reasonable. I think it might be good to also add a test to
> src/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc to
catch
> this.

Added Java test for the case that was failing.

[wychen, 2016-06-23 00:51:28]

https://codereview.chromium.org/2060423003/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java
(right):

https://codereview.chromium.org/2060423003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java:24:
* Tests related to the Tab's theme color.
This needs to be updated.

https://codereview.chromium.org/2060423003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java:43:
private void assertColorsEqual(int color1, int color2) {
Remove this.

https://codereview.chromium.org/2060423003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java:76:

nit: extra line

[mdjones, 2016-06-23 16:41:19]

https://codereview.chromium.org/2060423003/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java
(right):

https://codereview.chromium.org/2060423003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java:24:
* Tests related to the Tab's theme color.
On 2016/06/23 00:51:28, wychen wrote:
> This needs to be updated.

Copy paste problems :P. Done.

https://codereview.chromium.org/2060423003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java:43:
private void assertColorsEqual(int color1, int color2) {
On 2016/06/23 00:51:28, wychen wrote:
> Remove this.

Done.

https://codereview.chromium.org/2060423003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java:76:

On 2016/06/23 00:51:28, wychen wrote:
> nit: extra line

Done.

[wychen, 2016-06-23 17:17:50]

lgtm

[mdjones, 2016-06-23 17:22:00]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-06-23 17:22:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060423003/40001

[commit-bot: I haz the power, 2016-06-23 17:24:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 17:24:13]

Try jobs failed on following builders:
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mdjones, 2016-06-24 15:49:29]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-06-24 15:49:30]

The patchset sent to the CQ was uploaded after l-g-t-m from wychen@chromium.org
Link to the patchset: https://codereview.chromium.org/2060423003/#ps60001
(title: "rebase on mojo api change")

[commit-bot: I haz the power, 2016-06-24 15:49:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 16:57:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 16:57:19]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mdjones, 2016-06-27 16:48:26]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mdjones, 2016-06-27 16:48:27]

+dfalcantara for ChromeActivity.java

[gone, 2016-06-27 17:10:17]

lgtm

[mdjones, 2016-06-27 17:11:09]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-06-27 17:11:09]

The patchset sent to the CQ was uploaded after l-g-t-m from wychen@chromium.org
Link to the patchset: https://codereview.chromium.org/2060423003/#ps80001
(title: "Add VisibleForTesting to ChromeActivity")

[commit-bot: I haz the power, 2016-06-27 17:11:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 19:01:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-27 19:04:13]

Description was changed from

==========
Watch for RenderFrameHost switch in distillability

When navigating to/from a native page, the RenderFrameHost would
switch and the distillability service would lose connection. This
would cause Reader Mode to be broken for a few navigations. The
DistillabilityDriver now listens for this switch and updates the
service accordingly.

BUG=615327
==========

to

==========
Watch for RenderFrameHost switch in distillability

When navigating to/from a native page, the RenderFrameHost would
switch and the distillability service would lose connection. This
would cause Reader Mode to be broken for a few navigations. The
DistillabilityDriver now listens for this switch and updates the
service accordingly.

BUG=615327

Committed: https://crrev.com/acf19900a4a4dafcbac2ef2258522abf5f81ba9c
Cr-Commit-Position: refs/heads/master@{#402245}
==========

[commit-bot: I haz the power, 2016-06-27 19:04:14]

Patchset 5 (id:??) landed as
https://crrev.com/acf19900a4a4dafcbac2ef2258522abf5f81ba9c
Cr-Commit-Position: refs/heads/master@{#402245}