components/dom_distiller/content/browser/distillability_driver.h - Issue 2060423003: Watch for RenderFrameHost switch in distillability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/browser/distillability_driver.h

Issue 2060423003: Watch for RenderFrameHost switch in distillability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add VisibleForTesting to ChromeActivity Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/dom_distiller/content/browser/distillability_driver.h

diff --git a/components/dom_distiller/content/browser/distillability_driver.h b/components/dom_distiller/content/browser/distillability_driver.h

index eb25f0a37ab08032bab6cdc4a641e80ca2c9f48b..7e2ca447b076e29f5ed568054bf8598aa3dc3d91 100644

--- a/components/dom_distiller/content/browser/distillability_driver.h

+++ b/components/dom_distiller/content/browser/distillability_driver.h

@@ -31,13 +31,16 @@ class DistillabilityDriver

const GURL& validated_url,

bool is_error_page,

bool is_iframe_srcdoc) override;

+ void RenderFrameHostChanged(

+ content::RenderFrameHost* old_host,

+ content::RenderFrameHost* new_host) override;

private:

explicit DistillabilityDriver(content::WebContents* web_contents);

friend class content::WebContentsUserData<DistillabilityDriver>;

friend class DistillabilityServiceImpl;

- void SetupMojoService();

+ void SetupMojoService(content::RenderFrameHost* frame_host);

void OnDistillability(bool distillable, bool is_last);

base::Callback<void(bool, bool)> m_delegate_;