Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 20604002: Add Diagnose Errors button to navigation error page (Closed)

Created:
7 years, 4 months ago by Zachary Kuznia
Modified:
7 years, 4 months ago
Reviewers:
Dmitry Polukhin, Nico
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix to be ChromeOS only #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/localized_error.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/resources/neterror.html View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Zachary Kuznia
Please take a look.
7 years, 4 months ago (2013-07-26 00:28:12 UTC) #1
Dmitry Polukhin
lgtm
7 years, 4 months ago (2013-07-26 00:31:55 UTC) #2
Dmitry Polukhin
https://codereview.chromium.org/20604002/diff/1/chrome/renderer/resources/neterror.html File chrome/renderer/resources/neterror.html (right): https://codereview.chromium.org/20604002/diff/1/chrome/renderer/resources/neterror.html#newcode346 chrome/renderer/resources/neterror.html:346: <button id="diagnose-button" onclick="diagnoseErrors()" Please show this button only in ...
7 years, 4 months ago (2013-07-26 00:33:41 UTC) #3
Zachary Kuznia
https://codereview.chromium.org/20604002/diff/1/chrome/renderer/resources/neterror.html File chrome/renderer/resources/neterror.html (right): https://codereview.chromium.org/20604002/diff/1/chrome/renderer/resources/neterror.html#newcode346 chrome/renderer/resources/neterror.html:346: <button id="diagnose-button" onclick="diagnoseErrors()" On 2013/07/26 00:33:41, Dmitry Polukhin wrote: ...
7 years, 4 months ago (2013-07-26 00:54:41 UTC) #4
Zachary Kuznia
Hi Nico, Could you do an OWNERS review of this? Thanks, -Zach
7 years, 4 months ago (2013-07-26 00:57:43 UTC) #5
Dmitry Polukhin
LGTM
7 years, 4 months ago (2013-07-26 01:00:20 UTC) #6
Nico
code lgtm, but the bug is pretty light on the details: what's this extension, why ...
7 years, 4 months ago (2013-07-26 22:02:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/20604002/15001
7 years, 4 months ago (2013-07-26 23:04:52 UTC) #8
Zachary Kuznia
7 years, 4 months ago (2013-07-27 01:05:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r214016 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698