Chromium Code Reviews Chromium Code Reviews
Issue 20604002:
Add Diagnose Errors button to navigation error page (Closed)
Base URL: http://git.chromium.org/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html i18n-values="dir:textdirection"> | 2 <html i18n-values="dir:textdirection"> |
| 3 <head> | 3 <head> |
| 4 <meta name="viewport" content="width=device-width, initial-scale=1.0, | 4 <meta name="viewport" content="width=device-width, initial-scale=1.0, |
| 5 maximum-scale=1.0, user-scalable=no"> | 5 maximum-scale=1.0, user-scalable=no"> |
| 6 <title i18n-content="title"> | 6 <title i18n-content="title"> |
| 7 </title> | 7 </title> |
| 8 <style> | 8 <style> |
| 9 | 9 |
| 10 body { | 10 body { |
| (...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 294 var helpBoxOuter = document.getElementById('help-box-outer'); | 294 var helpBoxOuter = document.getElementById('help-box-outer'); |
| 295 helpBoxOuter.classList.toggle('hidden'); | 295 helpBoxOuter.classList.toggle('hidden'); |
| 296 var moreLessButton = document.getElementById('more-less-button'); | 296 var moreLessButton = document.getElementById('more-less-button'); |
| 297 if (helpBoxOuter.classList.contains('hidden')) { | 297 if (helpBoxOuter.classList.contains('hidden')) { |
| 298 moreLessButton.innerText = moreLessButton.moreText; | 298 moreLessButton.innerText = moreLessButton.moreText; |
| 299 } else { | 299 } else { |
| 300 moreLessButton.innerText = moreLessButton.lessText; | 300 moreLessButton.innerText = moreLessButton.lessText; |
| 301 } | 301 } |
| 302 } | 302 } |
| 303 | 303 |
| 304 function diagnoseErrors() { | |
| 305 location = "chrome-extension://kodldpbjkkmmnilagfdheibampofhaom/index.html"; | |
| 306 } | |
| 307 | |
| 304 // Subframes use a different layout but the same html file. This is to make it | 308 // Subframes use a different layout but the same html file. This is to make it |
| 305 // easier to support platforms that load the error page via different | 309 // easier to support platforms that load the error page via different |
| 306 // mechanisms (Currently just iOS). | 310 // mechanisms (Currently just iOS). |
| 307 if (window.top.location != window.location) | 311 if (window.top.location != window.location) |
| 308 document.documentElement.setAttribute('subframe', ''); | 312 document.documentElement.setAttribute('subframe', ''); |
| 309 | 313 |
| 310 function updateForDnsProbe(strings) { | 314 function updateForDnsProbe(strings) { |
| 311 var context = new JsEvalContext(strings); | 315 var context = new JsEvalContext(strings); |
| 312 jstProcess(context, document.getElementById('help-box-outer')); | 316 jstProcess(context, document.getElementById('help-box-outer')); |
| 313 jstProcess(context, document.getElementById('details')); | 317 jstProcess(context, document.getElementById('details')); |
| (...skipping 18 matching lines...) Expand all Loading... | |
| 332 <div id="help-box-outer" class="hidden"> | 336 <div id="help-box-outer" class="hidden"> |
| 333 <div id="help-box-inner"> | 337 <div id="help-box-inner"> |
| 334 <div jsselect="summary"> | 338 <div jsselect="summary"> |
| 335 <span jsvalues=".innerHTML:msg"></span> | 339 <span jsvalues=".innerHTML:msg"></span> |
| 336 </div> | 340 </div> |
| 337 | 341 |
| 338 <div class="suggestions" jsselect="suggestions"> | 342 <div class="suggestions" jsselect="suggestions"> |
| 339 <div class="suggestion-header" jsvalues=".innerHTML:header"></div> | 343 <div class="suggestion-header" jsvalues=".innerHTML:header"></div> |
| 340 <div class="suggestion-body" jsvalues=".innerHTML:body"></div> | 344 <div class="suggestion-body" jsvalues=".innerHTML:body"></div> |
| 341 </div> | 345 </div> |
| 346 <button id="diagnose-button" onclick="diagnoseErrors()" | |
|
Dmitry Polukhin
2013/07/26 00:33:41
Please show this button only in case of Chrome OS.
Zachary Kuznia
2013/07/26 00:54:41
Done.
| |
| 347 jscontent="diagnose">Diagnose</button> | |
| 342 <div class="error-code" jscontent="errorCode"></div> | 348 <div class="error-code" jscontent="errorCode"></div> |
| 343 </div> | 349 </div> |
| 344 </div> | 350 </div> |
| 345 </div> | 351 </div> |
| 346 </div> | 352 </div> |
| 347 <div id="sub-frame-error"> | 353 <div id="sub-frame-error"> |
| 348 <!-- Show details when hovering over the icon, in case the details are | 354 <!-- Show details when hovering over the icon, in case the details are |
| 349 hidden because they're too large. --> | 355 hidden because they're too large. --> |
| 350 <img class="error-img" jsvalues=".title:errorDetails"> | 356 <img class="error-img" jsvalues=".title:errorDetails"> |
| 351 <div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div> | 357 <div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div> |
| 352 </div> | 358 </div> |
| 353 </body> | 359 </body> |
| 354 </html> | 360 </html> |
| OLD | NEW |
