Adds implementation of BackgroundScheduler.unschedule()

Adds implementation of BackgroundScheduler.unschedule()

BUG=619686
Committed: https://crrev.com/4ffa8efab5bc0c6737ff4b7ff616c938661c5520
Cr-Commit-Position: refs/heads/master@{#399641}

[dougarnett, 2016-06-13 20:09:47]

Description was changed from

==========
Adds implementation of BackgroundScheduler.unschedule()

BUG=619686
==========

to

==========
Adds implementation of BackgroundScheduler.unschedule()

BUG=619686
==========

[dougarnett, 2016-06-13 20:09:47]

dougarnett@chromium.org changed reviewers:
+ petewil@google.com

[Pete Williamson, 2016-06-13 20:50:25]

petewil@chromium.org changed reviewers:
+ petewil@chromium.org

[Pete Williamson, 2016-06-13 20:50:26]

https://codereview.chromium.org/2060353003/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
(right):

https://codereview.chromium.org/2060353003/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java:46:
long beforeScheduleMillis = System.currentTimeMillis();
Should we use some kind of test clock instead of the system current time?

https://codereview.chromium.org/2060353003/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java:69:
assertNotNull(ShadowGcmNetworkManager.getCanceledTask());
Should we assert that the cancelled task is the same as the task we scheduled
instead of just non-null?

[dougarnett, 2016-06-13 21:21:00]

dougarnett@chromium.org changed reviewers:
- petewil@google.com

[dougarnett, 2016-06-13 21:21:41]

https://codereview.chromium.org/2060353003/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
(right):

https://codereview.chromium.org/2060353003/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java:46:
long beforeScheduleMillis = System.currentTimeMillis();
On 2016/06/13 20:50:26, Pete Williamson wrote:
> Should we use some kind of test clock instead of the system current time?

Not sure it is worth the extra complexity. Actually, just verifying that a
positive value is set and plumbed through is main value here - so can back off
to just check that and avoid any occasional flakey failure from more precise
comparison if clock gets adjusted.

https://codereview.chromium.org/2060353003/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java:69:
assertNotNull(ShadowGcmNetworkManager.getCanceledTask());
On 2016/06/13 20:50:26, Pete Williamson wrote:
> Should we assert that the cancelled task is the same as the task we scheduled
> instead of just non-null?

Started with some of that but wasn't so meaningful here (no actual details at
this level about how tasks get matched up) and ended up making the Shadow
implementation more sophisticated (as it knows the cancelTask arguments) such
that non-null here seems sufficient.

[Pete Williamson, 2016-06-13 21:34:03]

lgtm

[dougarnett, 2016-06-13 21:56:07]

The CQ bit was checked by dougarnett@chromium.org

[commit-bot: I haz the power, 2016-06-13 21:57:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060353003/20001

[commit-bot: I haz the power, 2016-06-13 23:51:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 23:51:45]

Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[dougarnett, 2016-06-14 01:52:02]

The CQ bit was checked by dougarnett@chromium.org

[commit-bot: I haz the power, 2016-06-14 01:52:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060353003/20001

[commit-bot: I haz the power, 2016-06-14 02:17:11]

Description was changed from

==========
Adds implementation of BackgroundScheduler.unschedule()

BUG=619686
==========

to

==========
Adds implementation of BackgroundScheduler.unschedule()

BUG=619686
==========

[commit-bot: I haz the power, 2016-06-14 02:17:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-14 03:40:14]

Description was changed from

==========
Adds implementation of BackgroundScheduler.unschedule()

BUG=619686
==========

to

==========
Adds implementation of BackgroundScheduler.unschedule()

BUG=619686

Committed: https://crrev.com/4ffa8efab5bc0c6737ff4b7ff616c938661c5520
Cr-Commit-Position: refs/heads/master@{#399641}
==========

[commit-bot: I haz the power, 2016-06-14 03:40:15]

Patchset 2 (id:??) landed as
https://crrev.com/4ffa8efab5bc0c6737ff4b7ff616c938661c5520
Cr-Commit-Position: refs/heads/master@{#399641}