Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java

Issue 2060353003: Adds implementation of BackgroundScheduler.unschedule() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revises schedule time validation to just be sure positive value is set for now Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
index 02b34952581fa5f36333e98bc20f5c6b0c212b7b..1c2da05ed6e419d4dedfdbc9dbc047bbccea0a4a 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
@@ -4,11 +4,15 @@
package org.chromium.chrome.browser.offlinepages;
+import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
import android.content.Context;
+import com.google.android.gms.gcm.Task;
+
import org.chromium.base.BaseChromiumApplication;
import org.chromium.base.test.util.Feature;
import org.chromium.testing.local.LocalRobolectricTestRunner;
@@ -31,6 +35,7 @@ public class BackgroundSchedulerTest {
@Before
public void setUp() throws Exception {
mContext = Robolectric.application;
+ ShadowGcmNetworkManager.clear();
}
@Test
@@ -42,12 +47,23 @@ public class BackgroundSchedulerTest {
// Check with gcmNetworkManagerShadow that schedule got called.
assertNotNull(ShadowGcmNetworkManager.getScheduledTask());
- // TODO(petewil): Also assert that the date we see is what we expected
+ // Verify details of the scheduled task.
+ Task task = ShadowGcmNetworkManager.getScheduledTask();
+ assertEquals(OfflinePageUtils.TASK_TAG, task.getTag());
+ long scheduledTimeMillis = TaskExtrasPacker.unpackTimeFromBundle(task.getExtras());
+ assertTrue(scheduledTimeMillis > 0L);
}
@Test
@Feature({"OfflinePages"})
public void testUnschedule() {
- // TODO(petewil): Add this test.
+ BackgroundScheduler scheduler = new BackgroundScheduler();
+ assertNull(ShadowGcmNetworkManager.getScheduledTask());
+ scheduler.schedule(mContext);
+ assertNotNull(ShadowGcmNetworkManager.getScheduledTask());
+
+ assertNull(ShadowGcmNetworkManager.getCanceledTask());
+ scheduler.unschedule(mContext);
+ assertNotNull(ShadowGcmNetworkManager.getCanceledTask());
}
}

Powered by Google App Engine
This is Rietveld 408576698