Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8872)

Unified Diff: chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js

Issue 2060023002: WebUI: cr-search-field: Remove delegation pattern, use simple event instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@search_box0
Patch Set: Address comments, fix compilation. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js
diff --git a/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js b/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js
index f93743f117d6c25b390ad190132c6fa0aa9655e2..1101688b10253dcb712c27d2a5c48f6dcc5fd633 100644
--- a/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js
+++ b/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js
@@ -7,9 +7,10 @@ cr.define('cr_toolbar_search_field', function() {
function registerTests() {
suite('cr-toolbar-search-field', function() {
/** @type {?CrToolbarSearchFieldElement} */
- var field;
- /** @type {?MockSearchFieldDelegate} */
- var delegate;
+ var field = null;
+
+ /** @type {?Array<string>} */
+ var searches = null;
/** @param {string} term */
function simulateSearch(term) {
@@ -17,22 +18,6 @@ cr.define('cr_toolbar_search_field', function() {
field.onSearchTermSearch();
}
- /**
- * @constructor
- * @implements {SearchFieldDelegate}
- */
- function MockSearchFieldDelegate() {
- /** @type {!Array<string>} */
- this.searches = [];
- }
-
- MockSearchFieldDelegate.prototype = {
- /** @override */
- onSearchTermSearch: function(term) {
- this.searches.push(term);
- }
- };
-
suiteSetup(function() {
return PolymerTest.importHtml(
'chrome://resources/cr_elements/cr_toolbar/' +
@@ -41,17 +26,18 @@ cr.define('cr_toolbar_search_field', function() {
setup(function() {
PolymerTest.clearBody();
- // Constructing a new delegate resets the list of searches.
- delegate = new MockSearchFieldDelegate();
field = document.createElement('cr-toolbar-search-field');
- field.setDelegate(delegate);
+ searches = [];
+ field.addEventListener('search-changed', function(event) {
+ searches.push(event.detail);
+ });
document.body.appendChild(field);
});
teardown(function() {
field.remove();
field = null;
- delegate = null;
+ searches = null;
});
test('opens and closes correctly', function() {
@@ -85,7 +71,7 @@ cr.define('cr_toolbar_search_field', function() {
// Expecting identical query to be ignored.
simulateSearch('query2');
- assertEquals(['query1', '', 'query2'].join(), delegate.searches.join());
+ assertEquals(['query1', '', 'query2'].join(), searches.join());
});
test('blur does not close field when a search is active', function() {

Powered by Google App Engine
This is Rietveld 408576698