chrome/browser/resources/md_extensions/toolbar.js - Issue 2060023002: WebUI: cr-search-field: Remove delegation pattern, use simple event instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_extensions/toolbar.js

Issue 2060023002: WebUI: cr-search-field: Remove delegation pattern, use simple event instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@search_box0

Patch Set: Address comments, fix compilation. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_extensions/manager.js ('K') | « chrome/browser/resources/md_extensions/manager.js ('k') | chrome/browser/resources/md_history/history_toolbar.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_extensions/toolbar.js

diff --git a/chrome/browser/resources/md_extensions/toolbar.js b/chrome/browser/resources/md_extensions/toolbar.js

index 3da624cc6de96a7cd2e23d8d1ddbff77ed3e5b6c..0752f1035dba0c5f813ebaca0c06dfd4d0d200e5 100644

--- a/chrome/browser/resources/md_extensions/toolbar.js

+++ b/chrome/browser/resources/md_extensions/toolbar.js

@@ -5,11 +5,6 @@

cr.define('extensions', function() {

var Toolbar = Polymer({

is: 'extensions-toolbar',

Dan Beam 2016/06/14 22:13:29 i wonder what the point of keeping this as a custo

dpapad 2016/06/14 22:28:16 Don't see a point in keeping this custom element a

- /** @param {SearchFieldDelegate} delegate */

- setSearchDelegate: function(delegate) {

- this.$['search-field'].setDelegate(delegate);

- },

});

return {Toolbar: Toolbar};