Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3313)

Unified Diff: chrome/browser/resources/md_extensions/manager.js

Issue 2060023002: WebUI: cr-search-field: Remove delegation pattern, use simple event instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@search_box0
Patch Set: Address comments, fix compilation. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_extensions/manager.js
diff --git a/chrome/browser/resources/md_extensions/manager.js b/chrome/browser/resources/md_extensions/manager.js
index c90d7f88114ae693ce85195bfebd7717d4d200a5..24dc45556cd3037c5d1db808a29267aec903be85 100644
--- a/chrome/browser/resources/md_extensions/manager.js
+++ b/chrome/browser/resources/md_extensions/manager.js
@@ -91,11 +91,18 @@ cr.define('extensions', function() {
/** @type {extensions.Sidebar} */(this.$$('extensions-sidebar'));
this.listHelper_ = new ListHelper(this);
this.sidebar.setListDelegate(this.listHelper_);
- this.$.toolbar.setSearchDelegate(new SearchHelper(this));
this.readyPromiseResolver.resolve();
},
/**
+ * @param {!CustomEvent} event
+ * @private
+ */
+ onFilterChanged_: function(event) {
+ this.filter = /** @type {string} */ (event.detail);
Devlin 2016/06/14 20:07:44 nit: I think no space between */ and (event.detail
Dan Beam 2016/06/14 22:11:20 i think i originally discouraged this, but clang f
+ },
+
+ /**
* @param {chrome.developerPrivate.ExtensionType} type The type of item.
* @return {string} The ID of the list that the item belongs in.
* @private
@@ -277,21 +284,5 @@ cr.define('extensions', function() {
},
};
- /**
- * @param {extensions.Manager} manager
- * @constructor
- * @implements {SearchFieldDelegate}
- */
- function SearchHelper(manager) {
- this.manager_ = manager;
- }
-
- SearchHelper.prototype = {
- /** @override */
- onSearchTermSearch: function(searchTerm) {
- this.manager_.filter = searchTerm;
- },
- };
-
return {Manager: Manager};
});

Powered by Google App Engine
This is Rietveld 408576698