ash: Add a unit test for the system update tray item

ash: Add a unit test for the system update tray item

I'm about to refactor SystemTrayNotifier and TrayUpdate, and I want more
confidence that I'm not breaking it.

This also changes the default "update required" state in ash unit tests to not
having an update.

BUG=619181
TEST=ash_unittests TrayUpdateTest

Committed: https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940
Cr-Commit-Position: refs/heads/master@{#399388}

[James Cook, 2016-06-10 22:20:22]

jamescook@chromium.org changed reviewers:
+ stevenjb@chromium.org

[James Cook, 2016-06-10 22:20:23]

Steven, please take a look.

[stevenjb, 2016-06-10 22:56:31]

lgtm

https://codereview.chromium.org/2060003002/diff/20001/ash/system/tray/system_...
File ash/system/tray/system_tray.h (right):

https://codereview.chromium.org/2060003002/diff/20001/ash/system/tray/system_...
ash/system/tray/system_tray.h:161: TrayUpdate* GetTrayUpdateForTesting() const;
nit: Replace the comments in 155 and 158 with "Unit test getters" (or just
remove them all)

[James Cook, 2016-06-10 23:15:03]

Thanks for the quick review.

https://codereview.chromium.org/2060003002/diff/20001/ash/system/tray/system_...
File ash/system/tray/system_tray.h (right):

https://codereview.chromium.org/2060003002/diff/20001/ash/system/tray/system_...
ash/system/tray/system_tray.h:161: TrayUpdate* GetTrayUpdateForTesting() const;
On 2016/06/10 22:56:30, stevenjb wrote:
> nit: Replace the comments in 155 and 158 with "Unit test getters" (or just
> remove them all)

I removed the comments, the method names are enough.

[James Cook, 2016-06-10 23:15:13]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-10 23:15:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2060003002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-06-10 23:16:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060003002/40001

[commit-bot: I haz the power, 2016-06-11 00:06:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-11 00:06:53]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-06-11 23:34:45]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-11 23:34:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2060003002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-11 23:34:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060003002/100001

[commit-bot: I haz the power, 2016-06-12 00:34:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-12 00:34:52]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-06-12 05:53:07]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-06-12 05:53:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060003002/100001

[commit-bot: I haz the power, 2016-06-12 07:03:05]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-12 07:05:19]

Description was changed from

==========
ash: Add a unit test for the system update tray item

I'm about to refactor SystemTrayNotifier and TrayUpdate, and I want more
confidence that I'm not breaking it.

This also changes the default "update required" state in ash unit tests to not
having an update.

BUG=619181
TEST=ash_unittests TrayUpdateTest
==========

to

==========
ash: Add a unit test for the system update tray item

I'm about to refactor SystemTrayNotifier and TrayUpdate, and I want more
confidence that I'm not breaking it.

This also changes the default "update required" state in ash unit tests to not
having an update.

BUG=619181
TEST=ash_unittests TrayUpdateTest

Committed: https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940
Cr-Commit-Position: refs/heads/master@{#399388}
==========

[commit-bot: I haz the power, 2016-06-12 07:05:20]

Patchset 6 (id:??) landed as
https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940
Cr-Commit-Position: refs/heads/master@{#399388}