build/sanitizers/BUILD.gn - Issue 2059843002: gn: Add chromium_builder_asan target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/sanitizers/BUILD.gn

Issue 2059843002: gn: Add chromium_builder_asan target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cros Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/sanitizers/BUILD.gn

diff --git a/build/sanitizers/BUILD.gn b/build/sanitizers/BUILD.gn

index 4f81f3ebadd0b5071c2dce7322af16251c1739bc..40ffcb7469d052abf6581f3732c6a1a7a21e5351 100644

--- a/build/sanitizers/BUILD.gn

+++ b/build/sanitizers/BUILD.gn

@@ -2,8 +2,7 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-if (is_linux && !is_chromeos) {

- # TODO(GYP): Figure out which of these work and are needed on other platforms.

+if (is_clang) {

Dirk Pranke 2016/06/10 17:47:09 So this'll exist in every checkout that uses clang

Nico 2016/06/10 17:50:45 Yes, it's part of the clang prebuilt bundle. (I g

copy("copy_llvm_symbolizer") {

if (is_win) {

sources = [