Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 20598008: Add maxTouchPoints for pointer events (Closed)

Created:
7 years, 4 months ago by sblom
Modified:
7 years, 2 months ago
Reviewers:
Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

I need to move this issue to the email address that I used on the CLA, so closing this one and opening a new one. >_< Replacement: https://codereview.chromium.org/27750002

Patch Set 1 #

Total comments: 4

Patch Set 2 : maxTouchPoints the right way #

Total comments: 3

Patch Set 3 : Add maxTouchPoints for pointer events #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M Source/core/frame/Navigator.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/Navigator.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/frame/Navigator.idl View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/page/Settings.in View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M public/web/WebSettings.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Rick Byers
https://codereview.chromium.org/20598008/diff/1/Source/modules/modules.gypi File Source/modules/modules.gypi (right): https://codereview.chromium.org/20598008/diff/1/Source/modules/modules.gypi#newcode182 Source/modules/modules.gypi:182: 'pointerevents/NavigatorPointerEvents.idl', I'm not sure if a 'module' is really ...
7 years, 4 months ago (2013-08-07 13:46:51 UTC) #1
sblom
Updated this with the architecture that you helped me settle on.
7 years, 2 months ago (2013-10-10 20:54:17 UTC) #2
Rick Byers
Looking good, almost there! Please add a CL description including: - a link to the ...
7 years, 2 months ago (2013-10-10 22:12:17 UTC) #3
sblom
7 years, 2 months ago (2013-10-17 17:44:27 UTC) #4
Message was sent while issue was closed.
I'll have what I think is a final draft of both this patch and its chromium
companion this afternoon.

Powered by Google App Engine
This is Rietveld 408576698