Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2059783002: base: Fix error checked for SleepConditionVariableSRW(). (Closed)

Created:
4 years, 6 months ago by prashant.n
Modified:
4 years, 6 months ago
Reviewers:
danakj, robliao
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_notify_schedule_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Fix error checked for SleepConditionVariableSRW(). The error checked should be ERROR_TIMEOUT and DCHECK should be for error other than ERROR_TIMEOUT. Timeout is an expected error when timeout occurs. BUG=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/synchronization/condition_variable_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
prashant.n
ptal. Thought of patching, otherwise we would forget this.
4 years, 6 months ago (2016-06-10 14:50:17 UTC) #2
robliao
On 2016/06/10 14:50:17, prashant.n wrote: > ptal. Thought of patching, otherwise we would forget this. ...
4 years, 6 months ago (2016-06-10 15:03:57 UTC) #3
prashant.n
4 years, 6 months ago (2016-06-10 15:21:35 UTC) #4 
On 2016/06/10 15:03:57, robliao wrote:
> On 2016/06/10 14:50:17, prashant.n wrote:
> > ptal. Thought of patching, otherwise we would forget this.
> 
> Sorry, forgot to loop you into the other CL I started earlier today.
> https://codereview.chromium.org/2053403002/

No issues, your CL looks good to me.

Powered by Google App Engine
This is Rietveld 408576698