base/synchronization/condition_variable_win.cc - Issue 2059783002: base: Fix error checked for SleepConditionVariableSRW().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/condition_variable_win.cc

Issue 2059783002: base: Fix error checked for SleepConditionVariableSRW(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_notify_schedule_1

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/synchronization/condition_variable_win.cc

diff --git a/base/synchronization/condition_variable_win.cc b/base/synchronization/condition_variable_win.cc

index 61c6a715e0eccd8557338193f7f8313ab431b9ce..714572acfb94471bbc8c10a10c4e157750ed1e64 100644

--- a/base/synchronization/condition_variable_win.cc

+++ b/base/synchronization/condition_variable_win.cc

@@ -35,7 +35,7 @@ void ConditionVariable::TimedWait(const TimeDelta& max_time) {

#endif

if (FALSE == SleepConditionVariableSRW(&cv_, srwlock_, timeout, 0)) {

- DCHECK(GetLastError() != WAIT_TIMEOUT);

+ DCHECK(GetLastError() == ERROR_TIMEOUT);

}

#if DCHECK_IS_ON()

« no previous file with comments | « no previous file | no next file » | no next file with comments »