Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: sdch/sdch.gyp

Issue 205963004: always use -Wno-deprecated-declarations when building sdch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdch/sdch.gyp
diff --git a/sdch/sdch.gyp b/sdch/sdch.gyp
index af65409c9a37a8fdd0e43521abf05fbd1567532a..e71a2360892e8b5bddbe5ad166497fb560d42724 100644
--- a/sdch/sdch.gyp
+++ b/sdch/sdch.gyp
@@ -52,14 +52,14 @@
'open-vcdiff/src',
],
},
+ # TODO(mostynb): remove this if open-vcdiff is ever updated for c++11.
+ 'cflags': [ '-Wno-deprecated-declarations' ],
jochen (gone - plz use gerrit) 2014/03/20 16:19:01 does windows understand this? maybe we need os_pos
Nico 2014/03/20 16:23:05 Windows doesn't use 'cflags'. But gcc 4.6 might ge
Mostyn Bramley-Moore 2014/03/20 16:24:17 Oh, right. I always forget windows. Will do.
Nico 2014/03/20 16:25:05 Nonono, windows doesn't use cflags.
Mostyn Bramley-Moore 2014/03/20 16:29:23 OK, I'll move it back then.
'conditions': [
[ 'OS == "linux" or OS == "android"', { 'include_dirs': [ 'linux' ] } ],
[ 'os_bsd==1 or OS=="solaris"', { 'include_dirs': [ 'bsd' ] } ],
[ 'OS == "ios"', { 'include_dirs': [ 'ios' ] } ],
[ 'OS == "mac"', { 'include_dirs': [ 'mac' ] } ],
[ 'OS == "win"', { 'include_dirs': [ 'win' ] } ],
- # TODO(mark): Remove usage of the deprecated auto_ptr.
- [ 'clang == 1', { 'cflags': [ '-Wno-deprecated-declarations' ] } ],
],
# open-vcdiff's logging.h introduces static initializers. This was
# reported upstream years ago (
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698