always use -Wno-deprecated-declarations when building sdch

sdch/sdch.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'targets': [
     {
@@ skipping 34 matching lines @@
         'open-vcdiff/vsprojects/stdint.h',
       ],
       'include_dirs': [
         'open-vcdiff/src',
       ],
       'direct_dependent_settings': {
         'include_dirs': [
           'open-vcdiff/src',
         ],
       },
+      # TODO(mostynb): remove this if open-vcdiff is ever updated for c++11.
+      'cflags': [ '-Wno-deprecated-declarations' ],

[jochen (gone - plz use gerrit), 2014/03/20 16:19:01]

does windows understand this? maybe we need os_posix==1 or clang=="1" or
something?

[Nico, 2014/03/20 16:23:05]

Windows doesn't use 'cflags'. But gcc 4.6 might get confused by this?

[Mostyn Bramley-Moore, 2014/03/20 16:24:17]

Oh, right.  I always forget windows.  Will do.

[Nico, 2014/03/20 16:25:05]

Nonono, windows doesn't use cflags.

[Mostyn Bramley-Moore, 2014/03/20 16:29:23]

OK, I'll move it back then.

       'conditions': [
         [ 'OS == "linux" or OS == "android"', { 'include_dirs': [ 'linux' ] } ],
         [ 'os_bsd==1 or OS=="solaris"', { 'include_dirs': [ 'bsd' ] } ],
         [ 'OS == "ios"', { 'include_dirs': [ 'ios' ] } ],
         [ 'OS == "mac"', { 'include_dirs': [ 'mac' ] } ],
         [ 'OS == "win"', { 'include_dirs': [ 'win' ] } ],
-        # TODO(mark): Remove usage of the deprecated auto_ptr.
-        [ 'clang == 1', { 'cflags': [ '-Wno-deprecated-declarations' ] } ],
       ],
       # open-vcdiff's logging.h introduces static initializers. This was
       # reported upstream years ago (
       # https://code.google.com/p/open-vcdiff/issues/detail?id=33 ). Since
       # upstream won't fix this, work around it on the chromium side:
       # Inject a header that forwards to base/logging.h instead (which doesn't
       # introduce static initializers, and which prevents open-vcdiff's
       # logging.h from being used).
       'variables': {
         'logging_path': 'logging_forward.h',
@@ skipping 20 matching lines @@
           'ForcedIncludeFiles': [
             'intsafe_workaround.h',  # http://crbug.com/308740
             'sdch/<(logging_path)',
           ]
         }
       },
       'cflags': [ '-include', '<(logging_dir)/sdch/<(logging_path)' ],
     },
   ],
 }