always use -Wno-deprecated-declarations when building sdch

always use -Wno-deprecated-declarations when building sdch

This is also needed for c++11 mode in gcc 4.8, not just clang.

BUG=324299
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258918

[Mostyn Bramley-Moore, 2014-03-20 16:17:38]

PTAL.

[jochen (gone - plz use gerrit), 2014-03-20 16:19:00]

https://codereview.chromium.org/205963004/diff/1/sdch/sdch.gyp
File sdch/sdch.gyp (right):

https://codereview.chromium.org/205963004/diff/1/sdch/sdch.gyp#newcode56
sdch/sdch.gyp:56: 'cflags': [ '-Wno-deprecated-declarations' ],
does windows understand this? maybe we need os_posix==1 or clang=="1" or
something?

[Nico, 2014-03-20 16:23:05]

lgtm if trybots are happy

https://codereview.chromium.org/205963004/diff/1/sdch/sdch.gyp
File sdch/sdch.gyp (right):

https://codereview.chromium.org/205963004/diff/1/sdch/sdch.gyp#newcode56
sdch/sdch.gyp:56: 'cflags': [ '-Wno-deprecated-declarations' ],
On 2014/03/20 16:19:01, jochen wrote:
> does windows understand this? maybe we need os_posix==1 or clang=="1" or
> something?

Windows doesn't use 'cflags'. But gcc 4.6 might get confused by this?

[Mostyn Bramley-Moore, 2014-03-20 16:24:16]

https://codereview.chromium.org/205963004/diff/1/sdch/sdch.gyp
File sdch/sdch.gyp (right):

https://codereview.chromium.org/205963004/diff/1/sdch/sdch.gyp#newcode56
sdch/sdch.gyp:56: 'cflags': [ '-Wno-deprecated-declarations' ],
On 2014/03/20 16:19:01, jochen wrote:
> does windows understand this? maybe we need os_posix==1 or clang=="1" or
> something?

Oh, right.  I always forget windows.  Will do.

[Nico, 2014-03-20 16:25:05]

https://codereview.chromium.org/205963004/diff/1/sdch/sdch.gyp
File sdch/sdch.gyp (right):

https://codereview.chromium.org/205963004/diff/1/sdch/sdch.gyp#newcode56
sdch/sdch.gyp:56: 'cflags': [ '-Wno-deprecated-declarations' ],
On 2014/03/20 16:24:17, Mostyn Bramley-Moore wrote:
> On 2014/03/20 16:19:01, jochen wrote:
> > does windows understand this? maybe we need os_posix==1 or clang=="1" or
> > something?
> 
> Oh, right.  I always forget windows.  Will do.

Nonono, windows doesn't use cflags.

[Mostyn Bramley-Moore, 2014-03-20 16:29:22]

https://codereview.chromium.org/205963004/diff/1/sdch/sdch.gyp
File sdch/sdch.gyp (right):

https://codereview.chromium.org/205963004/diff/1/sdch/sdch.gyp#newcode56
sdch/sdch.gyp:56: 'cflags': [ '-Wno-deprecated-declarations' ],
On 2014/03/20 16:25:05, Nico (on GMT time Mar 15 - 24) wrote:
> On 2014/03/20 16:24:17, Mostyn Bramley-Moore wrote:
> > On 2014/03/20 16:19:01, jochen wrote:
> > > does windows understand this? maybe we need os_posix==1 or clang=="1" or
> > > something?
> > 
> > Oh, right.  I always forget windows.  Will do.
> 
> Nonono, windows doesn't use cflags.

OK, I'll move it back then.

[Mostyn Bramley-Moore, 2014-03-20 16:34:57]

gcc >= 4.4 silently ignores any -Wno-* flags it doesn't recognise btw.

[Mostyn Bramley-Moore, 2014-03-24 11:25:23]

Since this change only affects compiler warnings/errors, and this seems to
successfully compile on linux_rel, android_rel, mac_rel, win_rel and
linux_clang, I think this change is safe.  The testrun failures must surely be
unrelated.  I have therefore added NOTRY=true to the CL description...

@Mark: can you give this an OWNERS thumbs-up?

[Mark Mentovai, 2014-03-24 13:04:05]

LGTM

[Mostyn Bramley-Moore, 2014-03-24 13:06:06]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2014-03-24 13:06:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/205963004/60001

[commit-bot: I haz the power, 2014-03-24 13:06:59]

Change committed as 258918