Disable "taking address of packed member" clang warning.

Disable "taking address of packed member" clang warning.

Pending cleanup.

BUG=619640
Committed: https://crrev.com/e77a373b7141f2e52f79f5cba5c2577fc16a4f5e
Cr-Commit-Position: refs/heads/master@{#399572}

[Evgeniy Stepanov, 2016-06-13 18:29:50]

Description was changed from

==========
Disable "taking address of packed member" clang warning.

Pending cleanup.

BUG=619640
==========

to

==========
Disable "taking address of packed member" clang warning.

Pending cleanup.

BUG=619640
==========

[Evgeniy Stepanov, 2016-06-13 18:29:50]

eugenis@google.com changed reviewers:
+ dpranke@chromium.org, hans@chromium.org

[Evgeniy Stepanov, 2016-06-13 18:30:04]

The CQ bit was checked by eugenis@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 18:30:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2059143003/1

[Evgeniy Stepanov, 2016-06-13 18:31:35]

I could not really test this change on GYP because I keep getting "-w" in my
compiler flags, unlike the bot.

[hans, 2016-06-13 18:36:46]

Thanks for fixing!

https://codereview.chromium.org/2059143003/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/2059143003/diff/1/build/common.gypi#newcode2634
build/common.gypi:2634: "-Wno-address-of-packed-member",
Since this is a new warning flag, the currently used Clang version will error
complaining that it does know the flag.

The flag needs to be added conditionally (also for gn), see e.g.
https://codereview.chromium.org/2040533003

[commit-bot: I haz the power, 2016-06-13 18:41:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 18:41:10]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Evgeniy Stepanov, 2016-06-13 19:47:23]

PTAL

[Evgeniy Stepanov, 2016-06-13 19:49:11]

The CQ bit was checked by eugenis@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 19:49:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2059143003/20001

[hans, 2016-06-13 19:51:03]

lgtm

[commit-bot: I haz the power, 2016-06-13 20:06:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 20:06:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evgeniy Stepanov, 2016-06-13 20:44:35]

The CQ bit was checked by eugenis@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 20:45:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2059143003/40001

[Evgeniy Stepanov, 2016-06-13 20:56:01]

The CQ bit was unchecked by eugenis@google.com

[Evgeniy Stepanov, 2016-06-13 20:56:11]

The CQ bit was checked by eugenis@google.com

[Evgeniy Stepanov, 2016-06-13 20:56:12]

The patchset sent to the CQ was uploaded after l-g-t-m from hans@chromium.org
Link to the patchset: https://codereview.chromium.org/2059143003/#ps40001
(title: "Disable "taking address of packed member" clang warning.")

[commit-bot: I haz the power, 2016-06-13 20:57:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2059143003/40001

[commit-bot: I haz the power, 2016-06-13 21:09:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 21:09:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evgeniy Stepanov, 2016-06-13 21:45:38]

eugenis@google.com changed reviewers:
+ thakis@chromium.org

[Evgeniy Stepanov, 2016-06-13 21:45:38]

need owner lgtm

[hans, 2016-06-13 21:56:59]

Dirk seems to be out today.

I'd suggest tbr'ing thakis since this is fixing broken builds.

[Dirk Pranke, 2016-06-13 22:07:49]

lgtm

[Evgeniy Stepanov, 2016-06-13 22:10:18]

The CQ bit was checked by eugenis@google.com

[commit-bot: I haz the power, 2016-06-13 22:11:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2059143003/40001

[commit-bot: I haz the power, 2016-06-13 22:18:16]

Description was changed from

==========
Disable "taking address of packed member" clang warning.

Pending cleanup.

BUG=619640
==========

to

==========
Disable "taking address of packed member" clang warning.

Pending cleanup.

BUG=619640
==========

[commit-bot: I haz the power, 2016-06-13 22:18:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-13 22:21:17]

Description was changed from

==========
Disable "taking address of packed member" clang warning.

Pending cleanup.

BUG=619640
==========

to

==========
Disable "taking address of packed member" clang warning.

Pending cleanup.

BUG=619640

Committed: https://crrev.com/e77a373b7141f2e52f79f5cba5c2577fc16a4f5e
Cr-Commit-Position: refs/heads/master@{#399572}
==========

[commit-bot: I haz the power, 2016-06-13 22:21:18]

Patchset 3 (id:??) landed as
https://crrev.com/e77a373b7141f2e52f79f5cba5c2577fc16a4f5e
Cr-Commit-Position: refs/heads/master@{#399572}

[Nico, 2016-06-14 12:36:53]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2066503004/ by thakis@chromium.org.

The reason for reverting is: The warning got reverted upstream..