Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2040533003: Suppress -Wnonportable-include-path on clang tot bots (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : bug# #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M build/common.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Nico
4 years, 6 months ago (2016-06-03 22:20:12 UTC) #2
hans
lgtm https://codereview.chromium.org/2040533003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/2040533003/diff/1/build/common.gypi#newcode3064 build/common.gypi:3064: # TODO(thakis): https://crbug.com/604888 This looks like the wrong ...
4 years, 6 months ago (2016-06-03 22:22:28 UTC) #3
Nico
thanks, filed bug https://codereview.chromium.org/2040533003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/2040533003/diff/1/build/common.gypi#newcode3064 build/common.gypi:3064: # TODO(thakis): https://crbug.com/604888 thanks; copypasta error
4 years, 6 months ago (2016-06-03 22:27:20 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2bc751024e4ddf3f50594abdbf3c54b77df84562 Cr-Commit-Position: refs/heads/master@{#397823}
4 years, 6 months ago (2016-06-03 22:32:03 UTC) #7
Nico
Committed patchset #2 (id:20001) manually as 2bc751024e4ddf3f50594abdbf3c54b77df84562 (presubmit successful).
4 years, 6 months ago (2016-06-03 22:32:56 UTC) #9
hans
4 years, 6 months ago (2016-06-06 16:36:20 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2043813002/ by hans@chromium.org.

The reason for reverting is: The Clang warning was removed again in r271761..

Powered by Google App Engine
This is Rietveld 408576698