Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2059053002:
update webgl 2 expectations against builtin precision test cases (Closed)
Descriptionupdate webgl 2 expectations against builtin precision test cases
BUG=619403
TEST=gpu bots
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/5e10e9e68eb0f67f5718b4e10ce14f3ba65f6eee
Cr-Commit-Position: refs/heads/master@{#401719}
Patch Set 1 : update the webgl 2 expectations #Patch Set 2 : update webgl2 expectations #Patch Set 3 : code rebase #Patch Set 4 : code rebase #Patch Set 5 : update expectation #Messages
Total messages: 31 (14 generated)
Description was changed from ========== update webgl 2 expectations against builtin precision BUG=295792 ========== to ========== update webgl 2 expectations against builtin precision BUG=295792 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== update webgl 2 expectations against builtin precision BUG=295792 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== update webgl 2 expectations against builtin precision BUG=619403 TEST=gpu bots CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059053002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059053002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
yunchao.he@intel.com changed reviewers: + bajones@chromium.org, kbr@chromium.org, qiankun.miao@intel.com, zmo@chromium.org
Description was changed from ========== update webgl 2 expectations against builtin precision BUG=619403 TEST=gpu bots CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== update webgl 2 expectations against builtin precision test cases BUG=619403 TEST=gpu bots CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
PTAL. Thanks a lot!
On 2016/06/13 15:41:40, yunchao wrote: > PTAL. Thanks a lot! Yunchao, this CL looks good, but we can't land it right now because WebGL2 tests will be over 60 minutes limit per run on all platforms. Let's wait until sharding is turned on for WebGL2. kbr is working on that.
On 2016/06/13 15:43:23, Zhenyao Mo wrote: > On 2016/06/13 15:41:40, yunchao wrote: > > PTAL. Thanks a lot! > > Yunchao, this CL looks good, but we can't land it right now because WebGL2 tests > will be over 60 minutes limit per run on all platforms. > > Let's wait until sharding is turned on for WebGL2. kbr is working on that. Got it. It's OK. It is weird that bots failed, but all builtin precision related cases show [ OK ]... Is this caused by 60 minutes limit per run?
On 2016/06/13 15:48:03, yunchao wrote: > On 2016/06/13 15:43:23, Zhenyao Mo wrote: > > On 2016/06/13 15:41:40, yunchao wrote: > > > PTAL. Thanks a lot! > > > > Yunchao, this CL looks good, but we can't land it right now because WebGL2 > tests > > will be over 60 minutes limit per run on all platforms. > > > > Let's wait until sharding is turned on for WebGL2. kbr is working on that. > > Got it. It's OK. > > It is weird that bots failed, but all builtin precision related cases show [ OK > ]... Is this caused by 60 minutes limit per run? Yes, I think so (look at the running time, they are over 1 hour)
On 2016/06/13 15:49:41, Zhenyao Mo wrote: > On 2016/06/13 15:48:03, yunchao wrote: > > On 2016/06/13 15:43:23, Zhenyao Mo wrote: > > > On 2016/06/13 15:41:40, yunchao wrote: > > > > PTAL. Thanks a lot! > > > > > > Yunchao, this CL looks good, but we can't land it right now because WebGL2 > > tests > > > will be over 60 minutes limit per run on all platforms. > > > > > > Let's wait until sharding is turned on for WebGL2. kbr is working on that. > > > > Got it. It's OK. > > > > It is weird that bots failed, but all builtin precision related cases show [ > OK > > ]... Is this caused by 60 minutes limit per run? > > Yes, I think so (look at the running time, they are over 1 hour) Make sense. Thank you, zmo@. I tried to find out the reason why the bots failed today, but found nothing.
On 2016/06/13 15:53:32, yunchao wrote: > On 2016/06/13 15:49:41, Zhenyao Mo wrote: > > On 2016/06/13 15:48:03, yunchao wrote: > > > On 2016/06/13 15:43:23, Zhenyao Mo wrote: > > > > On 2016/06/13 15:41:40, yunchao wrote: > > > > > PTAL. Thanks a lot! > > > > > > > > Yunchao, this CL looks good, but we can't land it right now because WebGL2 > > > tests > > > > will be over 60 minutes limit per run on all platforms. > > > > > > > > Let's wait until sharding is turned on for WebGL2. kbr is working on that. > > > > > > Got it. It's OK. > > > > > > It is weird that bots failed, but all builtin precision related cases show [ > > OK > > > ]... Is this caused by 60 minutes limit per run? > > > > Yes, I think so (look at the running time, they are over 1 hour) > > Make sense. Thank you, zmo@. I tried to find out the reason why the bots failed > today, but found nothing. Seems that the bots still failed because of the 60 minutes limit per run. Is sharding turned on for WebGL2?
On 2016/06/17 16:09:37, yunchao wrote: > On 2016/06/13 15:53:32, yunchao wrote: > > On 2016/06/13 15:49:41, Zhenyao Mo wrote: > > > On 2016/06/13 15:48:03, yunchao wrote: > > > > On 2016/06/13 15:43:23, Zhenyao Mo wrote: > > > > > On 2016/06/13 15:41:40, yunchao wrote: > > > > > > PTAL. Thanks a lot! > > > > > > > > > > Yunchao, this CL looks good, but we can't land it right now because > WebGL2 > > > > tests > > > > > will be over 60 minutes limit per run on all platforms. > > > > > > > > > > Let's wait until sharding is turned on for WebGL2. kbr is working on > that. > > > > > > > > Got it. It's OK. > > > > > > > > It is weird that bots failed, but all builtin precision related cases show > [ > > > OK > > > > ]... Is this caused by 60 minutes limit per run? > > > > > > Yes, I think so (look at the running time, they are over 1 hour) > > > > Make sense. Thank you, zmo@. I tried to find out the reason why the bots > failed > > today, but found nothing. > > Seems that the bots still failed because of the 60 minutes limit per run. Is > sharding turned on for WebGL2? Not on yet. Should be soon.
On 2016/06/17 17:19:23, Zhenyao Mo wrote: > On 2016/06/17 16:09:37, yunchao wrote: > > On 2016/06/13 15:53:32, yunchao wrote: > > > On 2016/06/13 15:49:41, Zhenyao Mo wrote: > > > > On 2016/06/13 15:48:03, yunchao wrote: > > > > > On 2016/06/13 15:43:23, Zhenyao Mo wrote: > > > > > > On 2016/06/13 15:41:40, yunchao wrote: > > > > > > > PTAL. Thanks a lot! > > > > > > > > > > > > Yunchao, this CL looks good, but we can't land it right now because > > WebGL2 > > > > > tests > > > > > > will be over 60 minutes limit per run on all platforms. > > > > > > > > > > > > Let's wait until sharding is turned on for WebGL2. kbr is working on > > that. > > > > > > > > > > Got it. It's OK. > > > > > > > > > > It is weird that bots failed, but all builtin precision related cases > show > > [ > > > > OK > > > > > ]... Is this caused by 60 minutes limit per run? > > > > > > > > Yes, I think so (look at the running time, they are over 1 hour) > > > > > > Make sense. Thank you, zmo@. I tried to find out the reason why the bots > > failed > > > today, but found nothing. > > > > Seems that the bots still failed because of the 60 minutes limit per run. Is > > sharding turned on for WebGL2? > > Not on yet. Should be soon. Seems that sharding has been turned on. PTAL. Thanks a lot!
On 2016/06/23 15:37:38, yunchao wrote: > On 2016/06/17 17:19:23, Zhenyao Mo wrote: > > On 2016/06/17 16:09:37, yunchao wrote: > > > On 2016/06/13 15:53:32, yunchao wrote: > > > > On 2016/06/13 15:49:41, Zhenyao Mo wrote: > > > > > On 2016/06/13 15:48:03, yunchao wrote: > > > > > > On 2016/06/13 15:43:23, Zhenyao Mo wrote: > > > > > > > On 2016/06/13 15:41:40, yunchao wrote: > > > > > > > > PTAL. Thanks a lot! > > > > > > > > > > > > > > Yunchao, this CL looks good, but we can't land it right now because > > > WebGL2 > > > > > > tests > > > > > > > will be over 60 minutes limit per run on all platforms. > > > > > > > > > > > > > > Let's wait until sharding is turned on for WebGL2. kbr is working on > > > that. > > > > > > > > > > > > Got it. It's OK. > > > > > > > > > > > > It is weird that bots failed, but all builtin precision related cases > > show > > > [ > > > > > OK > > > > > > ]... Is this caused by 60 minutes limit per run? > > > > > > > > > > Yes, I think so (look at the running time, they are over 1 hour) > > > > > > > > Make sense. Thank you, zmo@. I tried to find out the reason why the bots > > > failed > > > > today, but found nothing. > > > > > > Seems that the bots still failed because of the 60 minutes limit per run. Is > > > sharding turned on for WebGL2? > > > > Not on yet. Should be soon. > > Seems that sharding has been turned on. PTAL. Thanks a lot! Sharding doesn't work for "nvidia gpu on mac retina" platform.
Description was changed from ========== update webgl 2 expectations against builtin precision test cases BUG=619403 TEST=gpu bots CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== update webgl 2 expectations against builtin precision test cases BUG=619403 TEST=gpu bots NOTRY=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
lgtm
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059053002/120001
Message was sent while issue was closed.
Description was changed from ========== update webgl 2 expectations against builtin precision test cases BUG=619403 TEST=gpu bots NOTRY=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== update webgl 2 expectations against builtin precision test cases BUG=619403 TEST=gpu bots NOTRY=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #5 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== update webgl 2 expectations against builtin precision test cases BUG=619403 TEST=gpu bots NOTRY=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== update webgl 2 expectations against builtin precision test cases BUG=619403 TEST=gpu bots NOTRY=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/5e10e9e68eb0f67f5718b4e10ce14f3ba65f6eee Cr-Commit-Position: refs/heads/master@{#401719} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/5e10e9e68eb0f67f5718b4e10ce14f3ba65f6eee Cr-Commit-Position: refs/heads/master@{#401719} |
