Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2058833002: [Merge to M52] [Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API. (Closed)

Created:
4 years, 6 months ago by xdai1
Modified:
4 years, 6 months ago
Reviewers:
bshe
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Merge to M52] [Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API. The original CL https://codereview.chromium.org/1986583002/ was reverted in https://codereview.chromium.org/1984953005/ because of memory leak detected in the test function getThumbnailAferSetWallpaper(). BUG=608895 TBR=bshe@chromium.org Review-Url: https://codereview.chromium.org/1989653002 Cr-Commit-Position: refs/heads/master@{#396411} (cherry picked from commit fffb22c1b808e247ce67cb35793b57ddb35bf1d0) Committed: https://chromium.googlesource.com/chromium/src/+/59e1abe6af3205eea84d0bb6fb3890ca051e6b1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_api.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/test/data/extensions/api_test/wallpaper/test.js View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xdai1
4 years, 6 months ago (2016-06-10 16:09:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
59e1abe6af3205eea84d0bb6fb3890ca051e6b1d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698