Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1989653002:
[Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API. (Closed)
|
Created:
4 years, 7 months ago by xdai1 Modified:
4 years, 6 months ago Reviewers:
bshe CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API.
The original CL https://codereview.chromium.org/1986583002/ was reverted in
https://codereview.chromium.org/1984953005/ because of memory leak detected in
the test function getThumbnailAferSetWallpaper().
BUG=608895
Committed: https://crrev.com/fffb22c1b808e247ce67cb35793b57ddb35bf1d0
Cr-Commit-Position: refs/heads/master@{#396411}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #
Messages
Total messages: 23 (12 generated)
Description was changed from ========== [Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API. BUG=608895 ========== to ========== [Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API. The original CL https://codereview.chromium.org/1986583002/ was reverted in https://codereview.chromium.org/1984953005/ because of memory leak detected in the test function getThumbnailAferSetWallpaper(). BUG=608895 ==========
Description was changed from ========== [Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API. The original CL https://codereview.chromium.org/1986583002/ was reverted in https://codereview.chromium.org/1984953005/ because of memory leak detected in the test function getThumbnailAferSetWallpaper(). BUG=608895 ========== to ========== [Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API. The original CL https://codereview.chromium.org/1986583002/ was reverted in https://codereview.chromium.org/1984953005/ because of memory leak detected in the test function getThumbnailAferSetWallpaper(). BUG=608895 ==========
xdai@chromium.org changed reviewers: + bshe@chromium.org
Biao, could you help review this CL please? This is a retry of https://codereview.chromium.org/1986583002/. Thanks!
On 2016/05/17 22:33:55, xdai1 wrote: > Biao, could you help review this CL please? This is a retry of > https://codereview.chromium.org/1986583002/. Thanks! kindly ping?
On 2016/05/19 17:55:04, xdai1 wrote: > On 2016/05/17 22:33:55, xdai1 wrote: > > Biao, could you help review this CL please? This is a retry of > > https://codereview.chromium.org/1986583002/. Thanks! > > kindly ping? ping again?
On 2016/05/26 16:38:49, xdai1 wrote: > On 2016/05/19 17:55:04, xdai1 wrote: > > On 2016/05/17 22:33:55, xdai1 wrote: > > > Biao, could you help review this CL please? This is a retry of > > > https://codereview.chromium.org/1986583002/. Thanks! > > > > kindly ping? > > ping again? lgtm sorry I missed this one
The CQ bit was checked by xdai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989653002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by xdai@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org Link to the patchset: https://codereview.chromium.org/1989653002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989653002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989653002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by xdai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989653002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989653002/60001
Message was sent while issue was closed.
Description was changed from ========== [Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API. The original CL https://codereview.chromium.org/1986583002/ was reverted in https://codereview.chromium.org/1984953005/ because of memory leak detected in the test function getThumbnailAferSetWallpaper(). BUG=608895 ========== to ========== [Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API. The original CL https://codereview.chromium.org/1986583002/ was reverted in https://codereview.chromium.org/1984953005/ because of memory leak detected in the test function getThumbnailAferSetWallpaper(). BUG=608895 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API. The original CL https://codereview.chromium.org/1986583002/ was reverted in https://codereview.chromium.org/1984953005/ because of memory leak detected in the test function getThumbnailAferSetWallpaper(). BUG=608895 ========== to ========== [Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API. The original CL https://codereview.chromium.org/1986583002/ was reverted in https://codereview.chromium.org/1984953005/ because of memory leak detected in the test function getThumbnailAferSetWallpaper(). BUG=608895 Committed: https://crrev.com/fffb22c1b808e247ce67cb35793b57ddb35bf1d0 Cr-Commit-Position: refs/heads/master@{#396411} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/fffb22c1b808e247ce67cb35793b57ddb35bf1d0 Cr-Commit-Position: refs/heads/master@{#396411} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
