InstantExtended: record initial focus state for omnibox interactions.

chrome/browser/metrics/metrics_log.cc

Index: chrome/browser/metrics/metrics_log.cc
diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc
index db64070cb808c251f2ae1003a4dfb6af27cbeb16..ade8e2e5acff47d0866e683f4947f1fc7994a0e1 100644
--- a/chrome/browser/metrics/metrics_log.cc
+++ b/chrome/browser/metrics/metrics_log.cc
@@ -154,11 +154,17 @@ OmniboxEventProto::PageClassification AsOmniboxEventPageClassification(
       return OmniboxEventProto::HOMEPAGE;
     case AutocompleteInput::OTHER:
       return OmniboxEventProto::OTHER;
-    case AutocompleteInput::INSTANT_NEW_TAB_PAGE:
-      return OmniboxEventProto::INSTANT_NEW_TAB_PAGE;
+    case AutocompleteInput::OBSOLETE_INSTANT_NEW_TAB_PAGE:
+      return OmniboxEventProto::OBSOLETE_INSTANT_NEW_TAB_PAGE;

[Ilya Sherman, 2013/08/02 21:47:32]

nit: NOTREACHED()?  Maybe you could even remove the enum value on the
AutocompleteInput side?

[Mark P, 2013/08/02 21:53:24]

You realize this suggestion is the exact opposite of the previous code you
suggested and reviewed? :-)
https://codereview.chromium.org/20747002/

[Ilya Sherman, 2013/08/02 22:01:49]

How so?  I'm not recommending adding a default case for this switch stmt.  I'm
recommending removing the enumerated constant
AutocompleteInput::OBSOLETE_INSTANT_NEW_TAB_PAGE, which reduces the number of
cases that we need to handle in this switch stmt... while still preserving the
property that failing to handle new enumerated values would be a compile-time
error.

[Mark P, 2013/08/02 22:08:42]

Oh, yes, I misread your suggestion.  It sounds smart.  Let's do it.

[Mark P, 2013/08/06 17:22:14]

Please take this suggestion from Ilya before you submit.

[samarth, 2013/08/06 17:30:45]

Oops sorry.  Thanks for catching that.  Done.  (I left the field commented-out
in the file to ensure we don't accidentally reuse that value.)

[Mark P, 2013/08/06 17:34:14]

You might as well remove the value from autocomplete_input.  It's not stored
anywhere, and nothing bad will happen if reuse that enum value.  (Obviously,
keep the enum value in the proto file; we need to not reuse that one.)

[samarth, 2013/08/06 17:43:03]

OK, done.

     case AutocompleteInput::SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT:
       return OmniboxEventProto::
           SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT;
+    case AutocompleteInput::INSTANT_NEW_TAB_PAGE_WITH_OMNIBOX_AS_STARTING_FOCUS:
+      return OmniboxEventProto::
+          INSTANT_NEW_TAB_PAGE_WITH_OMNIBOX_AS_STARTING_FOCUS;
+    case AutocompleteInput::INSTANT_NEW_TAB_PAGE_WITH_FAKEBOX_AS_STARTING_FOCUS:
+      return OmniboxEventProto::
+          INSTANT_NEW_TAB_PAGE_WITH_FAKEBOX_AS_STARTING_FOCUS;
   }
   return OmniboxEventProto::INVALID_SPEC;
 }