InstantExtended: record initial focus state for omnibox interactions.

chrome/browser/autocomplete/autocomplete_input.h

Index: chrome/browser/autocomplete/autocomplete_input.h
diff --git a/chrome/browser/autocomplete/autocomplete_input.h b/chrome/browser/autocomplete/autocomplete_input.h
index 00708724e8a88eaf0147b5cc778603f84447cb30..9013b6a4e99322676cb1556e3c1886d37e597d76 100644
--- a/chrome/browser/autocomplete/autocomplete_input.h
+++ b/chrome/browser/autocomplete/autocomplete_input.h
@@ -58,11 +58,17 @@ class AutocompleteInput {
     // Note that if the homepage is set to the new tab page or about blank,
     // then we'll classify the web page into those categories, not HOMEPAGE.
     OTHER = 4,          // everything not included somewhere else on this list
-    INSTANT_NEW_TAB_PAGE = 5,  // new tab page rendered by Instant
+    OBSOLETE_INSTANT_NEW_TAB_PAGE = 5,  // new tab page rendered by Instant
     // The user is on a search result page that's doing search term
     // replacement, meaning the search terms should've appeared in the omnibox
     // before the user started editing it, not the URL of the page.
-    SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6
+    SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6,
+    // The new tab page in which this omnibox interaction first started
+    // with the user having focus in the omnibox.
+    INSTANT_NEW_TAB_PAGE_WITH_OMNIBOX_AS_STARTING_FOCUS = 7,

[Peter Kasting, 2013/08/02 17:59:38]

It's inappropriate to add this data here.  This enum is explicitly about "the
type of page currently displayed".  This split that you've added does not
distinguish between page types, instead it adds in another piece of orthogonal
data.  One could easily imagine adding such a split to all the other types, and
then having a third piece of data that we want to include and doubling all the
states again, etc.

Capture the data you need by looking at an additional piece of info somewhere,
do not include it in the PageClassification.

[Mark P, 2013/08/02 18:10:39]

I explicitly asked him to include it in PageClassification.  I think you're
right that now the name of and comment by the enum is misleading.  Perhaps
OmniboxContext or OmniboxEntryPoint might be better.

+    // The new tab page in which this omnibox interaction first started
+    // with the user having focus in the fakebox.
+    INSTANT_NEW_TAB_PAGE_WITH_FAKEBOX_AS_STARTING_FOCUS = 8,
   };
 
   AutocompleteInput();