Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2058633004:
Remove all the @FlakyTest annotations in ImeTest (Closed)
|
Created:
4 years, 6 months ago by yabinh Modified:
4 years, 6 months ago Reviewers:
Changwan Ryu CC:
aelias_OOO_until_Jul13 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionThere are 6 flaky tests in ImeTest. They are flaky because when we call
InputConnection#setSelection and other methods together, the order of messages
sometimes does not get kept.
We can solve this by enabling IME thread, because when IME thead is on,
the order can be kept.
Another way is applying the following patch, which deals with the re-ordering
issue: https://codereview.chromium.org/1877073003/. Since the patch has been
landed, we can remove the @FlakyTest annotations.
BUG=598482, 603991
Committed: https://crrev.com/6f23392b1f1f2b91909f646bc5ddf54c2c4003a6
Cr-Commit-Position: refs/heads/master@{#400099}
Patch Set 1 : Solve the flaky problem by enabling Ime Thread #Patch Set 2 : Remove all the @FlakyTest annotations in ImeTest #Patch Set 3 : Remove all the @FlakyTest annotations in ImeTest & fix another flaky test #
Messages
Total messages: 22 (14 generated)
Description was changed from ========== If IME thread is enabled, the flaky problem can be solved. If IME thread is not enabled, it will not wait for render to update selection in waitAndVerifyUpdateSelection(). So the selection could be wrong. Another way to fix this without enabling IME thread is applying this cl: https://codereview.chromium.org/1877073003/ BUG=598482 ========== to ========== If IME thread is enabled, the flaky problem can be solved. If IME thread is not enabled, it will not wait for render to update selection in waitAndVerifyUpdateSelection(). So the selection could be wrong. Another way to fix this without enabling IME thread is applying this cl: https://codereview.chromium.org/1877073003/ BUG=598482 ==========
yabinh@chromium.org changed reviewers: + changwan@chromium.org
Description was changed from ========== If IME thread is enabled, the flaky problem can be solved. If IME thread is not enabled, it will not wait for render to update selection in waitAndVerifyUpdateSelection(). So the selection could be wrong. Another way to fix this without enabling IME thread is applying this cl: https://codereview.chromium.org/1877073003/ BUG=598482 ========== to ========== When we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. Thus some tests could be flaky. We can solve this by applying this patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/ Another way is enabling IME thread, because when IME thead is on, the order can be kept. BUG=598482 ==========
Description was changed from ========== When we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. Thus some tests could be flaky. We can solve this by applying this patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/ Another way is enabling IME thread, because when IME thead is on, the order can be kept. BUG=598482 ========== to ========== When we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. Thus some tests could be flaky. We can solve this by applying this patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/ Another way is enabling IME thread, because when IME thead is on, the order can be kept. BUG=598482 ==========
Description was changed from ========== When we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. Thus some tests could be flaky. We can solve this by applying this patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/ Another way is enabling IME thread, because when IME thead is on, the order can be kept. BUG=598482 ========== to ========== When we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. Thus some tests could be flaky. We can solve this by applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/ Another way is enabling IME thread, because when IME thead is on, the order can be kept. BUG=598482 ==========
Description was changed from ========== When we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. Thus some tests could be flaky. We can solve this by applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/ Another way is enabling IME thread, because when IME thead is on, the order can be kept. BUG=598482 ========== to ========== When we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. Thus some tests could be flaky. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/ BUG=598482 ==========
Description was changed from ========== When we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. Thus some tests could be flaky. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/ BUG=598482 ========== to ========== There are 6 flaky tests in ImeTest. There are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482 ==========
Description was changed from ========== There are 6 flaky tests in ImeTest. There are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482 ========== to ========== There are 6 flaky tests in ImeTest. There are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482 ==========
Description was changed from ========== There are 6 flaky tests in ImeTest. There are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482 ========== to ========== There are 6 flaky tests in ImeTest. There are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482 ==========
Description was changed from ========== There are 6 flaky tests in ImeTest. There are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482 ========== to ========== There are 6 flaky tests in ImeTest. They are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482 ==========
On 2016/06/10 02:47:59, yabinh wrote: After this patch(https://codereview.chromium.org/1877073003/) was landed, I ran the 6 flaky tests for several hundred of times(with or without Ime thread enabled), and found that this bug didn't show up. Before the above patch was landed, it showed up quite often without Ime thread enabled . Thus, we can remove the @FlakyTest annotations in Imetest safely. changwan@, can you take another look of this patch?
lgtm
Description was changed from ========== There are 6 flaky tests in ImeTest. They are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482 ========== to ========== There are 6 flaky tests in ImeTest. They are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482, 603991 ==========
The CQ bit was checked by yabinh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058633004/20001
Message was sent while issue was closed.
Description was changed from ========== There are 6 flaky tests in ImeTest. They are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482, 603991 ========== to ========== There are 6 flaky tests in ImeTest. They are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482, 603991 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== There are 6 flaky tests in ImeTest. They are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482, 603991 ========== to ========== There are 6 flaky tests in ImeTest. They are flaky because when we call InputConnection#setSelection and other methods together, the order of messages sometimes does not get kept. We can solve this by enabling IME thread, because when IME thead is on, the order can be kept. Another way is applying the following patch, which deals with the re-ordering issue: https://codereview.chromium.org/1877073003/. Since the patch has been landed, we can remove the @FlakyTest annotations. BUG=598482, 603991 Committed: https://crrev.com/6f23392b1f1f2b91909f646bc5ddf54c2c4003a6 Cr-Commit-Position: refs/heads/master@{#400099} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6f23392b1f1f2b91909f646bc5ddf54c2c4003a6 Cr-Commit-Position: refs/heads/master@{#400099}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2070083003/ by grunell@chromium.org. The reason for reverting is: Flaky failure seen in https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg.... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
