Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 2058633004: Remove all the @FlakyTest annotations in ImeTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove all the @FlakyTest annotations in ImeTest & fix another flaky test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bin/draw_gl/draw_gl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
index defe535a5a9867a8f6f767fc9637f89724f4a21a..4107dd9394ccaefe302975ab7c4e0feb68bcb916 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
@@ -24,7 +24,6 @@ import android.view.inputmethod.InputConnection;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
-import org.chromium.base.test.util.FlakyTest;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
@@ -110,7 +109,6 @@ public class ImeTest extends ContentShellTestBase {
@MediumTest
@Feature({"TextInput", "Main"})
- @FlakyTest
public void testDoesNotHang_getTextAfterKeyboardHides() throws Throwable {
setComposingText("hello", 1);
waitAndVerifyUpdateSelection(0, 5, 5, 0, 5);
@@ -238,7 +236,6 @@ public class ImeTest extends ContentShellTestBase {
@SmallTest
@Feature({"TextInput"})
- @FlakyTest(message = "crbug.com/603991")
public void testImeCopy() throws Exception {
commitText("hello", 1);
waitAndVerifyUpdateSelection(0, 5, 5, -1, -1);
@@ -579,7 +576,6 @@ public class ImeTest extends ContentShellTestBase {
@SmallTest
@Feature({"TextInput"})
- @FlakyTest(message = "crbug.com/603991")
public void testImeCut() throws Exception {
commitText("snarful", 1);
waitAndVerifyUpdateSelection(0, 7, 7, -1, -1);
@@ -633,16 +629,6 @@ public class ImeTest extends ContentShellTestBase {
@MediumTest
@Feature({"TextInput"})
public void testPasteLongText() throws Exception {
- ThreadUtils.runOnUiThreadBlocking(new Runnable() {
- @Override
- public void run() {
- ClipboardManager clipboardManager =
- (ClipboardManager) getActivity().getSystemService(
- Context.CLIPBOARD_SERVICE);
- clipboardManager.setPrimaryClip(ClipData.newPlainText("blarg", "blarg"));
- }
- });
-
int textLength = 25000;
String text = new String(new char[textLength]).replace("\0", "a");
@@ -671,7 +657,6 @@ public class ImeTest extends ContentShellTestBase {
@SmallTest
@Feature({"TextInput"})
- @FlakyTest(message = "crbug.com/598482")
public void testImeSelectAndUnSelectAll() throws Exception {
commitText("hello", 1);
waitAndVerifyUpdateSelection(0, 5, 5, -1, -1);
@@ -771,7 +756,6 @@ public class ImeTest extends ContentShellTestBase {
@SmallTest
@Feature({"TextInput", "Main"})
- @FlakyTest
public void testSwipingText() throws Throwable {
focusElement("textarea");
@@ -1083,7 +1067,6 @@ public class ImeTest extends ContentShellTestBase {
@SmallTest
@Feature({"TextInput"})
- @FlakyTest(message = "crbug.com/598482")
public void testPastePopupShowAndHide() throws Throwable {
commitText("hello", 1);
waitAndVerifyUpdateSelection(0, 5, 5, -1, -1);
« no previous file with comments | « bin/draw_gl/draw_gl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698