Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1754)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Issue 2058593002: Add UMA for studying download cancellation reasons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
index 261c49437b2b4be97e0d46e64372a001d8038293..82d7e28086751dc8869b2dd87d23c1f65cfb3bcd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
@@ -1101,12 +1101,14 @@ public class DownloadManagerService extends BroadcastReceiver implements
/**
* Called to cancel a download.
* @param downloadGuid GUID of the download.
+ * @param isNotificationDismissed Whether cancel is caused by dismissing the notification.
*/
- void cancelDownload(String downloadGuid) {
+ void cancelDownload(String downloadGuid, boolean isNotificationDismissed) {
DownloadProgress progress = mDownloadProgressMap.get(downloadGuid);
boolean isOffTheRecord = progress == null
? false : progress.mDownloadItem.getDownloadInfo().isOffTheRecord();
- nativeCancelDownload(getNativeDownloadManagerService(), downloadGuid, isOffTheRecord);
+ nativeCancelDownload(getNativeDownloadManagerService(), downloadGuid, isOffTheRecord,
+ isNotificationDismissed);
recordDownloadFinishedUMA(DOWNLOAD_STATUS_CANCELLED, downloadGuid, 0);
}
@@ -1460,6 +1462,7 @@ public class DownloadManagerService extends BroadcastReceiver implements
private native void nativeResumeDownload(
long nativeDownloadManagerService, String downloadGuid);
private native void nativeCancelDownload(
- long nativeDownloadManagerService, String downloadGuid, boolean isOffTheRecord);
+ long nativeDownloadManagerService, String downloadGuid, boolean isOffTheRecord,
+ boolean isNotificationDismissed);
private native void nativePauseDownload(long nativeDownloadManagerService, String downloadGuid);
}

Powered by Google App Engine
This is Rietveld 408576698