Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: content/public/browser/android/download_controller_android.h

Issue 2058593002: Add UMA for studying download cancellation reasons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/android/download_controller_android.h
diff --git a/content/public/browser/android/download_controller_android.h b/content/public/browser/android/download_controller_android.h
index 7eda0e9774b3202944c1e47469fbde90f2ff309b..ce2bb920d3342cf5275ab9c2684a67c933ef2c2f 100644
--- a/content/public/browser/android/download_controller_android.h
+++ b/content/public/browser/android/download_controller_android.h
@@ -25,6 +25,15 @@ class CONTENT_EXPORT DownloadControllerAndroid : public DownloadItem::Observer {
static void SetDownloadControllerAndroid(
DownloadControllerAndroid* download_controller);
+ enum DownloadCancelReason {
Ilya Sherman 2016/06/10 21:20:43 nit: Please document that this enum is used to bac
qinmin 2016/06/11 00:13:00 Done.
+ kActionButton = 0,
+ kNotificationDismissed,
+ kOverwriteInfobarDismissed,
+ kNoStoragePermission, // new enums must be added after this.
+ kCancelReasonMax
Ilya Sherman 2016/06/10 21:20:43 nit: Also, please either define this as an enum cl
Ilya Sherman 2016/06/10 21:20:43 nit: Please use SHOUTY_CASE for enum names, per ht
qinmin 2016/06/11 00:13:00 Done.
qinmin 2016/06/11 00:13:00 Done.
+ };
+ static void RecordDownloadCancelReason(DownloadCancelReason reason);
+
// Starts a new download request with Android. Should be called on the
// UI thread.
virtual void CreateGETDownload(int render_process_id, int render_view_id,

Powered by Google App Engine
This is Rietveld 408576698