Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 20585004: Fix metrics on Windows. (Closed)

Created:
7 years, 4 months ago by bungeman-skia
Modified:
7 years, 4 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix metrics on Windows. With this change, Skia's metrics are much better in general, and specifically can be made to match the metrics produced by current Blink code. This allows Blink to use Skia's metrics. This change will require a number of rebaselines in Skia, since previous metrics were quite different. This will require about five rebaslines in Blink, as the new code may cause GDI's matrix to differ in the low bits. Committed: https://code.google.com/p/skia/source/detail?r=10399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+658 lines, -159 lines) Patch
M src/core/SkScalerContext.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/core/SkScalerContext.cpp View 6 chunks +85 lines, -15 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 25 chunks +449 lines, -140 lines 0 comments Download
A tools/generate_fir_coeff.py View 1 chunk +119 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
bungeman-skia
7 years, 4 months ago (2013-07-27 20:37:59 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r10399 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698