Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 2058413002: Remove erroneous DCHECK related to expression classifiers (Closed)

Created:
4 years, 6 months ago by nickie
Modified:
4 years, 6 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove erroneous DCHECK related to expression classifiers It seems that I forgot to remove the DCHECK when refactoring this function, even though the comment had it right. It also seems that this is hard to trigger. The minimal example I found, after fuzzer's bug, was: eval, x[eval] R=adamk@chromium.org BUG=chromium:619476 LOG=N Committed: https://crrev.com/cdec5e8d26c56067d6e9bbc86dc2d8de9778bc72 Cr-Commit-Position: refs/heads/master@{#36929}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/parsing/expression-classifier.h View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/regress-crbug-619476.js View 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
nickie
4 years, 6 months ago (2016-06-13 09:33:55 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058413002/1
4 years, 6 months ago (2016-06-13 09:35:27 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 10:06:02 UTC) #5
adamk
lgtm https://codereview.chromium.org/2058413002/diff/1/test/mjsunit/regress-crbug-619476.js File test/mjsunit/regress-crbug-619476.js (right): https://codereview.chromium.org/2058413002/diff/1/test/mjsunit/regress-crbug-619476.js#newcode1 test/mjsunit/regress-crbug-619476.js:1: // Copyright 2015 the V8 project authors. All ...
4 years, 6 months ago (2016-06-13 12:14:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058413002/1
4 years, 6 months ago (2016-06-13 12:31:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 12:34:00 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 12:34:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cdec5e8d26c56067d6e9bbc86dc2d8de9778bc72
Cr-Commit-Position: refs/heads/master@{#36929}

Powered by Google App Engine
This is Rietveld 408576698