Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/parsing/expression-classifier.h

Issue 2058413002: Remove erroneous DCHECK related to expression classifiers (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PARSING_EXPRESSION_CLASSIFIER_H 5 #ifndef V8_PARSING_EXPRESSION_CLASSIFIER_H
6 #define V8_PARSING_EXPRESSION_CLASSIFIER_H 6 #define V8_PARSING_EXPRESSION_CLASSIFIER_H
7 7
8 #include "src/messages.h" 8 #include "src/messages.h"
9 #include "src/parsing/scanner.h" 9 #include "src/parsing/scanner.h"
10 #include "src/parsing/token.h" 10 #include "src/parsing/token.h"
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
456 reported_errors_->Add(e, zone_); 456 reported_errors_->Add(e, zone_);
457 reported_errors_end_++; 457 reported_errors_end_++;
458 } 458 }
459 459
460 // Copies the error at position i of the list of reported errors, so that 460 // Copies the error at position i of the list of reported errors, so that
461 // it becomes the last error reported for this classifier. Position i 461 // it becomes the last error reported for this classifier. Position i
462 // could be either after the existing errors of this classifier (i.e., 462 // could be either after the existing errors of this classifier (i.e.,
463 // in an inner classifier) or it could be an existing error (in case a 463 // in an inner classifier) or it could be an existing error (in case a
464 // copy is needed). 464 // copy is needed).
465 V8_INLINE void Copy(int i) { 465 V8_INLINE void Copy(int i) {
466 DCHECK_LE(reported_errors_end_, i);
467 DCHECK_LT(i, reported_errors_->length()); 466 DCHECK_LT(i, reported_errors_->length());
468 if (reported_errors_end_ != i) 467 if (reported_errors_end_ != i)
469 reported_errors_->at(reported_errors_end_) = reported_errors_->at(i); 468 reported_errors_->at(reported_errors_end_) = reported_errors_->at(i);
470 reported_errors_end_++; 469 reported_errors_end_++;
471 } 470 }
472 471
473 Zone* zone_; 472 Zone* zone_;
474 ZoneList<typename Traits::Type::Expression>* non_patterns_to_rewrite_; 473 ZoneList<typename Traits::Type::Expression>* non_patterns_to_rewrite_;
475 ZoneList<Error>* reported_errors_; 474 ZoneList<Error>* reported_errors_;
476 DuplicateFinder* duplicate_finder_; 475 DuplicateFinder* duplicate_finder_;
(...skipping 18 matching lines...) Expand all
495 }; 494 };
496 495
497 496
498 #undef ERROR_CODES 497 #undef ERROR_CODES
499 498
500 499
501 } // namespace internal 500 } // namespace internal
502 } // namespace v8 501 } // namespace v8
503 502
504 #endif // V8_PARSING_EXPRESSION_CLASSIFIER_H 503 #endif // V8_PARSING_EXPRESSION_CLASSIFIER_H
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress-crbug-619476.js » ('j') | test/mjsunit/regress-crbug-619476.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698