blimp/client/core/blimp_contents_impl.cc - Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/blimp_contents_impl.cc

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core

Patch Set: Addressed code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/BUILD.gn ('K') | « blimp/client/core/blimp_contents_impl.h ('k') | blimp/client/core/blimp_contents_impl_unittest.cc » ('j') | blimp/client/core/blimp_contents_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/blimp_contents_impl.cc

diff --git a/blimp/client/core/blimp_contents_impl.cc b/blimp/client/core/blimp_contents_impl.cc

index 3e93e9240e82b6f48fafdffb511afe154fe3921a..9530fa8291723cadc1409c897a296b822cabb046 100644

--- a/blimp/client/core/blimp_contents_impl.cc

+++ b/blimp/client/core/blimp_contents_impl.cc

@@ -58,8 +58,9 @@ void BlimpContentsImpl::RemoveObserver(BlimpContentsObserver* observer) {

observers_.RemoveObserver(observer);

}

-void BlimpContentsImpl::NotifyURLLoaded(const GURL& url) {

- FOR_EACH_OBSERVER(BlimpContentsObserver, observers_, OnURLUpdated(url));

+void BlimpContentsImpl::OnNavigationStateChanged() {

+ FOR_EACH_OBSERVER(BlimpContentsObserver, observers_,

+ OnURLUpdated(navigation_controller_.GetURL()));

David Trainor- moved to gerrit 2016/07/25 15:57:31 Shouldn't this be OnNavigationStateChanged()? Sho

shaktisahu 2016/07/26 01:25:27 I think so. But then should BlimpContentsObserver

David Trainor- moved to gerrit 2016/07/27 16:55:00 Why? Does it need one?

}

} // namespace client