Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: blimp/client/core/blimp_contents_impl.cc

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core
Patch Set: Addressed code review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/core/blimp_contents_impl.h" 5 #include "blimp/client/core/blimp_contents_impl.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/supports_user_data.h" 8 #include "base/supports_user_data.h"
9 #include "blimp/client/public/blimp_contents_observer.h" 9 #include "blimp/client/public/blimp_contents_observer.h"
10 10
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 } 51 }
52 52
53 void BlimpContentsImpl::AddObserver(BlimpContentsObserver* observer) { 53 void BlimpContentsImpl::AddObserver(BlimpContentsObserver* observer) {
54 observers_.AddObserver(observer); 54 observers_.AddObserver(observer);
55 } 55 }
56 56
57 void BlimpContentsImpl::RemoveObserver(BlimpContentsObserver* observer) { 57 void BlimpContentsImpl::RemoveObserver(BlimpContentsObserver* observer) {
58 observers_.RemoveObserver(observer); 58 observers_.RemoveObserver(observer);
59 } 59 }
60 60
61 void BlimpContentsImpl::NotifyURLLoaded(const GURL& url) { 61 void BlimpContentsImpl::OnNavigationStateChanged() {
62 FOR_EACH_OBSERVER(BlimpContentsObserver, observers_, OnURLUpdated(url)); 62 FOR_EACH_OBSERVER(BlimpContentsObserver, observers_,
63 OnURLUpdated(navigation_controller_.GetURL()));
David Trainor- moved to gerrit 2016/07/25 15:57:31 Shouldn't this be OnNavigationStateChanged()? Sho
shaktisahu 2016/07/26 01:25:27 I think so. But then should BlimpContentsObserver
David Trainor- moved to gerrit 2016/07/27 16:55:00 Why? Does it need one?
63 } 64 }
64 65
65 } // namespace client 66 } // namespace client
66 } // namespace blimp 67 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698