blimp/client/core/android/blimp_navigation_controller_impl_android.h - Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/android/blimp_navigation_controller_impl_android.h

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core

Patch Set: Addressed code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/BUILD.gn ('K') | « blimp/client/core/BUILD.gn ('k') | blimp/client/core/android/blimp_navigation_controller_impl_android.cc » ('j') | blimp/client/core/blimp_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/android/blimp_navigation_controller_impl_android.h

diff --git a/blimp/client/core/android/blimp_navigation_controller_impl_android.h b/blimp/client/core/android/blimp_navigation_controller_impl_android.h

index 5e848ff8f51034b5c0cd19bc0c45721b3f76823e..9f4b7a50ca00fb2e656cbb933ebb81553f70ac75 100644

--- a/blimp/client/core/android/blimp_navigation_controller_impl_android.h

+++ b/blimp/client/core/android/blimp_navigation_controller_impl_android.h

@@ -32,6 +32,13 @@ class BlimpNavigationControllerImplAndroid {

jobject jobj,

const base::android::JavaParamRef<jstring>& jurl);

base::android::ScopedJavaLocalRef<jstring> GetURL(JNIEnv* env, jobject jobj);

+ jboolean CanGoBack(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj);

+ jboolean CanGoForward(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj);

+ void GoBack(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);

+ void GoForward(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);

+ void Reload(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);

private:

BlimpNavigationControllerImpl* blimp_navigation_controller_impl_;