Tied up BlimpNavigationController to NavigationFeature

blimp/client/core/blimp_contents_impl_unittest.cc

Index: blimp/client/core/blimp_contents_impl_unittest.cc
diff --git a/blimp/client/core/blimp_contents_impl_unittest.cc b/blimp/client/core/blimp_contents_impl_unittest.cc
index 3d4a7c0aea665325a069fb9b56ce9c21100bcd74..6c9ee278663b3f9ac247dab8315642a11f0fdbc3 100644
--- a/blimp/client/core/blimp_contents_impl_unittest.cc
+++ b/blimp/client/core/blimp_contents_impl_unittest.cc
@@ -4,9 +4,12 @@
 
 #include "blimp/client/core/blimp_contents_impl.h"
 
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "blimp/client/core/blimp_contents_impl.h"
 #include "blimp/client/core/public/blimp_contents_observer.h"
+#include "blimp/client/feature/mock_navigation_feature.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blimp {
@@ -31,6 +34,21 @@ class TestBlimpContentsObserver : public BlimpContentsObserver {
   DISALLOW_COPY_AND_ASSIGN(TestBlimpContentsObserver);
 };
 
+class TestBlimpNavigationControllerDelegate
+    : public BlimpNavigationControllerDelegate {
+ public:
+  TestBlimpNavigationControllerDelegate() = default;
+  ~TestBlimpNavigationControllerDelegate() override = default;
+
+ private:
+  void OnUrlChanged(const GURL& url) override {}

[David Trainor- moved to gerrit, 2016/06/29 17:27:15]

// BlimpNavigationControllerDelegate implementation.

[shaktisahu, 2016/07/19 21:45:29]

Done.

+  void OnFaviconChanged(const SkBitmap& favicon) override {}
+  void OnTitleChanged(const std::string& title) override {}
+  void OnLoadingChanged(bool loading) override {}
+  void OnPageLoadStatusUpdate(bool completed) override {}
+  DISALLOW_COPY_AND_ASSIGN(TestBlimpNavigationControllerDelegate);

[David Trainor- moved to gerrit, 2016/06/29 17:27:15]

New line before this?

[shaktisahu, 2016/07/19 21:45:29]

Done.

+};
+
 TEST(BlimpContentsImplTest, Basic) {
   base::MessageLoop loop;
   BlimpContentsImpl blimp_contents;
@@ -43,6 +61,12 @@ TEST(BlimpContentsImplTest, Basic) {
   TestBlimpContentsObserver observer2;
   blimp_contents.AddObserver(&observer2);
 
+  BlimpNavigationControllerImpl* nav_controller_impl =
+      static_cast<BlimpNavigationControllerImpl*>(&navigation_controller);
+  MockNavigationFeature feature;
+  feature.SetDelegate(1, nav_controller_impl);
+  nav_controller_impl->SetNavigationFeatureForTesting(&feature);
+
   navigation_controller.LoadURL(kExampleURL);
   loop.RunUntilIdle();