blimp/client/core/blimp_contents_impl.h - Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/blimp_contents_impl.h

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core

Patch Set: Hooked up the Java layer Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpNavigationControllerImpl.java ('k') | blimp/client/core/blimp_contents_impl.cc » ('j') | blimp/client/core/blimp_contents_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/blimp_contents_impl.h

diff --git a/blimp/client/core/blimp_contents_impl.h b/blimp/client/core/blimp_contents_impl.h

index 077796e63f03f5973637d2c1b22b99a405f9922d..315f57593de290a951c6e150b3d528deab50e0d5 100644

--- a/blimp/client/core/blimp_contents_impl.h

+++ b/blimp/client/core/blimp_contents_impl.h

@@ -47,7 +47,11 @@ class BlimpContentsImpl : public BlimpContents,

void RemoveObserver(BlimpContentsObserver* observer) override;

// BlimpNavigationControllerDelegate implementation.

- void NotifyURLLoaded(const GURL& url) override;

+ void OnUrlChanged(const GURL& url) override;

David Trainor- moved to gerrit 2016/06/29 17:27:15 How are these generally exposed through the normal

shaktisahu 2016/07/19 21:45:29 Changed it to OnNavigationStateChanged as we discu

+ void OnFaviconChanged(const SkBitmap& favicon) override;

+ void OnTitleChanged(const std::string& title) override;

+ void OnLoadingChanged(bool loading) override;

+ void OnPageLoadStatusUpdate(bool completed) override;

private:

// Handles the back/forward list and loading URLs.