Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4040)

Unified Diff: blimp/client/core/blimp_contents_impl.cc

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core
Patch Set: Hooked up the Java layer Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/blimp_contents_impl.cc
diff --git a/blimp/client/core/blimp_contents_impl.cc b/blimp/client/core/blimp_contents_impl.cc
index d3c16350908022bd82067bbd1417d88d72a8bc34..940974f85c8c1812be7553138995ca054591e0ce 100644
--- a/blimp/client/core/blimp_contents_impl.cc
+++ b/blimp/client/core/blimp_contents_impl.cc
@@ -58,9 +58,25 @@ void BlimpContentsImpl::RemoveObserver(BlimpContentsObserver* observer) {
observers_.RemoveObserver(observer);
}
-void BlimpContentsImpl::NotifyURLLoaded(const GURL& url) {
+void BlimpContentsImpl::OnUrlChanged(const GURL& url) {
FOR_EACH_OBSERVER(BlimpContentsObserver, observers_, OnURLUpdated(url));
}
+void BlimpContentsImpl::OnFaviconChanged(const SkBitmap& favicon) {
+ // TODO(shaktisahu): Propagate event to observers.
+}
+
+void BlimpContentsImpl::OnTitleChanged(const std::string& title) {
+ // TODO(shaktisahu): Propagate event to observers.
+}
+
+void BlimpContentsImpl::OnLoadingChanged(bool loading) {
+ // TODO(shaktisahu): Propagate event to observers.
+}
+
+void BlimpContentsImpl::OnPageLoadStatusUpdate(bool completed) {
+ // TODO(shaktisahu): Propagate event to observers.
+}
+
} // namespace client
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698