chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc ('k') | chrome/browser/ui/webui/signin/user_manager_screen_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

diff --git a/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc b/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

index 38c763fe7a95347be3c42b1d73c6296bf4260285..0608ef396e88f41c4d28f06c74e319cb9ed3f4bb 100644

--- a/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

+++ b/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

@@ -6,7 +6,9 @@

#include <stddef.h>

+#include <memory>

#include <set>

+#include <utility>

#include <vector>

#include "base/bind.h"

@@ -256,7 +258,8 @@ void SigninSupervisedUserImportHandler::SendExistingSupervisedUsers(

std::string name;

value->GetString(SupervisedUserSyncService::kName, &name);

- base::DictionaryValue* supervised_user = new base::DictionaryValue;

+ std::unique_ptr<base::DictionaryValue> supervised_user(

+ new base::DictionaryValue);

supervised_user->SetString("id", it.key());

supervised_user->SetString("name", name);

@@ -284,7 +287,7 @@ void SigninSupervisedUserImportHandler::SendExistingSupervisedUsers(

supervised_user_ids.find(it.key()) != supervised_user_ids.end();

supervised_user->SetBoolean("onCurrentDevice", on_current_device);

- supervised_users.Append(supervised_user);

+ supervised_users.Append(std::move(supervised_user));

}

// Resolve callback with response.