Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: chrome/browser/devtools/devtools_targets_ui.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: less comments more ownership Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/gtest_util.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_targets_ui.cc
diff --git a/chrome/browser/devtools/devtools_targets_ui.cc b/chrome/browser/devtools/devtools_targets_ui.cc
index 3b85cb0b453493b265fce4dadca15eb5344dec6f..ec4ed3cd5ac2f7bd911d73779621f6b9e36004cb 100644
--- a/chrome/browser/devtools/devtools_targets_ui.cc
+++ b/chrome/browser/devtools/devtools_targets_ui.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/devtools/devtools_targets_ui.h"
+#include <utility>
+
#include "base/location.h"
#include "base/memory/weak_ptr.h"
#include "base/single_thread_task_runner.h"
@@ -330,7 +332,8 @@ void AdbTargetsUIHandler::DeviceListChanged(
for (DevToolsAndroidBridge::RemoteDevices::const_iterator dit =
devices.begin(); dit != devices.end(); ++dit) {
DevToolsAndroidBridge::RemoteDevice* device = dit->get();
- base::DictionaryValue* device_data = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> device_data(
+ new base::DictionaryValue());
device_data->SetString(kAdbModelField, device->model());
device_data->SetString(kAdbSerialField, device->serial());
device_data->SetBoolean(kAdbConnectedField, device->is_connected());
@@ -345,7 +348,8 @@ void AdbTargetsUIHandler::DeviceListChanged(
for (DevToolsAndroidBridge::RemoteBrowsers::iterator bit =
browsers.begin(); bit != browsers.end(); ++bit) {
DevToolsAndroidBridge::RemoteBrowser* browser = bit->get();
- base::DictionaryValue* browser_data = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> browser_data(
+ new base::DictionaryValue());
browser_data->SetString(kAdbBrowserNameField, browser->display_name());
browser_data->SetString(kAdbBrowserUserField, browser->user());
browser_data->SetString(kAdbBrowserVersionField, browser->version());
@@ -377,10 +381,10 @@ void AdbTargetsUIHandler::DeviceListChanged(
targets_[target->GetId()] = target;
page_list->Append(target_data);
}
- browser_list->Append(browser_data);
+ browser_list->Append(std::move(browser_data));
}
- device_list.Append(device_data);
+ device_list.Append(std::move(device_data));
}
SendSerializedTargets(device_list);
}
« no previous file with comments | « base/test/gtest_util.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698