[som] Add revision range exapansion.

[som] Add revision range exapansion.

- Add a handler for /api/v1/revrange/:start/:end, redirects to a url for
  fetching all of the revisions expanded in json.
- Adds a som-rev-range element. It's an expand-on-tap widget that works very
  similarly to the old Sheriff-o-Matic.

BUG=619188
Committed: https://chromium.googlesource.com/infra/infra/+/ef19815c4d99f6c691bfd76ac525bb56980b3178

[seanmccullough1, 2016-06-13 21:53:04]

seanmccullough@google.com changed reviewers:
+ martiniss@chromium.org

[martiniss, 2016-06-13 22:01:04]

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
File go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html (right):

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html:50: let url =
`/api/v1/revrange/${start}/${end}`;
why ` instead of '?

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html:52:
fetch(url).then( (resp) => {
style elsewhere is then((

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html:60: debugger;
console.error ?

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html:67:
this.$.collapse.toggle();
should this be inside the then()? Or is it synchronous

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html:127:
_uberify: function(url) {
we really should make a global function for this :/

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
File go/src/infra/appengine/sheriff-o-matic/main.go (right):

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/main.go:468: func getRevRangeHandler(c
context.Context, w http.ResponseWriter, r *http.Request, p httprouter.Params) {
test me bro

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/main.go:469: start := p.ByName("start")
check these?

[seanmccullough1, 2016-06-13 23:27:38]

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
File go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html (right):

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html:50: let url =
`/api/v1/revrange/${start}/${end}`;
On 2016/06/13 22:01:03, martiniss wrote:
> why ` instead of '?

html5 template strings are contained in ``s. Note the ${end} that gets
substituted with the end variable from the current scope.

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html:52:
fetch(url).then( (resp) => {
On 2016/06/13 22:01:03, martiniss wrote:
> style elsewhere is then((

Done.

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html:60: debugger;
On 2016/06/13 22:01:03, martiniss wrote:
> console.error ?

Done.

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html:67:
this.$.collapse.toggle();
On 2016/06/13 22:01:03, martiniss wrote:
> should this be inside the then()? Or is it synchronous

It should immediately toggle the collapse for the user, whether or not any
network calls have to be made.

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html:127:
_uberify: function(url) {
On 2016/06/13 22:01:03, martiniss wrote:
> we really should make a global function for this :/

oops copypasta from another file. This isn't actually used here so I removed it.

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
File go/src/infra/appengine/sheriff-o-matic/main.go (right):

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/main.go:468: func getRevRangeHandler(c
context.Context, w http.ResponseWriter, r *http.Request, p httprouter.Params) {
On 2016/06/13 22:01:04, martiniss wrote:
> test me bro

Done.

https://codereview.chromium.org/2058173003/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/main.go:469: start := p.ByName("start")
On 2016/06/13 22:01:03, martiniss wrote:
> check these?

Done.

[martiniss, 2016-06-13 23:32:10]

lgtm

[seanmccullough1, 2016-06-13 23:32:58]

The CQ bit was checked by seanmccullough@google.com

[commit-bot: I haz the power, 2016-06-13 23:33:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058173003/40001

[commit-bot: I haz the power, 2016-06-13 23:43:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 23:43:56]

Try jobs failed on following builders:
  Infra Mac Tester on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/bu...)

[seanmccullough1, 2016-06-13 23:49:01]

The CQ bit was checked by seanmccullough@google.com

[seanmccullough1, 2016-06-13 23:49:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
martiniss@chromium.org
Link to the patchset: https://codereview.chromium.org/2058173003/#ps60001
(title: "no-message:)")

[commit-bot: I haz the power, 2016-06-13 23:49:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058173003/60001

[commit-bot: I haz the power, 2016-06-14 00:15:11]

Description was changed from

==========
[som] Add revision range exapansion.

- Add a handler for /api/v1/revrange/:start/:end, redirects to a url for
  fetching all of the revisions expanded in json.
- Adds a som-rev-range element. It's an expand-on-tap widget that works very
  similarly to the old Sheriff-o-Matic.

BUG=619188
==========

to

==========
[som] Add revision range exapansion.

- Add a handler for /api/v1/revrange/:start/:end, redirects to a url for
  fetching all of the revisions expanded in json.
- Adds a som-rev-range element. It's an expand-on-tap widget that works very
  similarly to the old Sheriff-o-Matic.

BUG=619188

Committed:
https://chromium.googlesource.com/infra/infra/+/ef19815c4d99f6c691bfd76ac525b...
==========

[commit-bot: I haz the power, 2016-06-14 00:15:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/ef19815c4d99f6c691bfd76ac525b...