Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html

Issue 2058173003: [som] Add revision range exapansion. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: no-message:) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html
diff --git a/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html b/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html
index 118b79a5ec5f1f514cded3b3dbd1f96ddb7afb03..2971ad30bd65d7dda7a0fb557dca6a56ae814e9e 100644
--- a/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html
+++ b/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure.html
@@ -13,6 +13,7 @@
<link rel="import" href="/bower_components/paper-item/paper-item.html">
<link rel="import" href="/bower_components/paper-progress/paper-progress.html">
<link rel="import" href="/bower_components/paper-toolbar/paper-toolbar.html">
+<link rel="import" href="/elements/som-rev-range.html">
<dom-module id="som-extension-build-failure">
<template>
@@ -89,8 +90,7 @@
<div id="regression-ranges">
<template is="dom-repeat" items="[[extension.regression_ranges]]" as="regressionRange" filter="_showRegressionRange">
<div>
- [[regressionRange.repo]]:
- <a target="_blank" href$="[[_regressionRangeLink(regressionRange)]]">[[_regressionRange(regressionRange)]]</a>
+ <som-rev-range range="[[regressionRange]]"></som-rev-range>
</div>
</template>
</div>
@@ -100,7 +100,7 @@
(function() {
'use strict';
- Polymer({
+ Polymer({
is: 'som-extension-build-failure',
properties: {
@@ -118,45 +118,6 @@
return extension && extension.builders && extension.builders.length > 0;
},
- _regressionRange: function(range) {
- if (!range.positions || range.positions.length == 0) {
- return '';
- }
-
- let start = this._parseCommitPosition(range.positions[0]);
- if (range.positions.length == 1) {
- return start;
- }
-
- let end = this._parseCommitPosition(
- range.positions[range.positions.length - 1]);
-
- if (start && end) {
- return `${start} - ${end}`;
- }
- },
-
- _regressionRangeLink: function(range) {
- if (!range.positions) {
- return '';
- }
- let end = this._parseCommitPosition(range.positions[0]);
- let start = end;
- if (range.positions.length > 1) {
- end = this._parseCommitPosition(
- range.positions[range.positions.length - 1]);
- }
- return 'http://test-results.appspot.com/revision_range?start=' +
- `${start}&end=${end}`;
- },
-
- _parseCommitPosition: function(pos) {
- let groups = /refs\/heads\/master@{#([0-9]+)}/.exec(pos);
- if (groups && groups.length == 2) {
- return groups[1];
- }
- },
-
_failureCount: function(builder) {
// The build number range is inclusive.
let numBuilds = builder.latest_failure - builder.first_failure + 1;
@@ -177,7 +138,7 @@
},
_showRegressionRange: function(range) {
- return this._regressionRange(range) && range.positions.length > 0;
+ return range.positions && range.positions.length > 0;
},
_uberify: function(url) {
« no previous file with comments | « no previous file | go/src/infra/appengine/sheriff-o-matic/elements/som-rev-range.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698