Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

Issue 2058133002: Fix DevTools support of worklets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moved MainThreadDebugger::callingContextCanAccessContext's logic to BindingSecurity Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
index c5231f3773fa64d14dffbbc95a5f4dbf01dd43f0..4fc292458970463a6949d23db79e9323341b9be0 100644
--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
@@ -189,16 +189,7 @@ void MainThreadDebugger::unmuteConsole()
bool MainThreadDebugger::callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target)
haraken 2016/06/29 00:23:35 Not directly related to the CL, but is there any r
Gleb Lanbin 2016/06/29 17:07:13 please see the reply from dgozman@ above in this t
{
- ExecutionContext* executionContext = toExecutionContext(target);
- ASSERT(executionContext);
-
- if (executionContext->isMainThreadWorkletGlobalScope()) {
- MainThreadWorkletGlobalScope* globalScope = toMainThreadWorkletGlobalScope(executionContext);
- return globalScope && BindingSecurity::shouldAllowAccessTo(m_isolate, toLocalDOMWindow(toDOMWindow(calling)), globalScope, DoNotReportSecurityError);
- }
-
- DOMWindow* window = toDOMWindow(target);
- return window && BindingSecurity::shouldAllowAccessTo(m_isolate, toLocalDOMWindow(toDOMWindow(calling)), window, DoNotReportSecurityError);
+ return BindingSecurity::shouldAllowAccessTo(m_isolate, calling, target, DoNotReportSecurityError);
}
int MainThreadDebugger::ensureDefaultContextInGroup(int contextGroupId)

Powered by Google App Engine
This is Rietveld 408576698